Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide "Other bookmarks" from bar #6043

Closed
Valinwolf opened this issue Sep 17, 2019 · 17 comments · Fixed by brave/brave-core#21918
Closed

Hide "Other bookmarks" from bar #6043

Valinwolf opened this issue Sep 17, 2019 · 17 comments · Fixed by brave/brave-core#21918

Comments

@Valinwolf
Copy link

Description

I want my bookmarks bar uncluttered, with only my "quick access" sites on it, however it adds the other bookmarks folder to the end of the bar.

Brave version (brave://version info)

Brave | 0.72.13 Chromium: 77.0.3865.65 (Official Build) unknown (64-bit)
-- | --
Revision | 87a331a3169cab563505fb44011058b904011ba1-refs/branch-heads/3865@{#726}
OS | Linux
JavaScript | V8 7.7.299.10
Flash | (Disabled)
User Agent | Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/77.0.3865.65 Safari/537.36
Command Line | /usr/lib/brave-nightly-bin/brave --disable-chrome-google-url-tracking-client --disable-domain-reliability --disable-features=AudioServiceOutOfProcess,UnifiedConsent,AutofillServerCommunication,LookalikeUrlNavigationSuggestionsUI --enable-dom-distiller --enable-features=NewExtensionUpdaterService,WebUIDarkMode,SimplifyHttpsIndicator --extensions-install-verification=enforce --no-pings --extension-content-verification=enforce_strict --enable-features=SimplifyHttpsIndicator,WebUIDarkMode,NewExtensionUpdaterService --disable-features=LookalikeUrlNavigationSuggestionsUI,AutofillServerCommunication,UnifiedConsent,AudioServiceOutOfProcess --flag-switches-begin --allow-insecure-localhost --extension-content-verification=enforce --load-media-router-component-extension=1 --pull-to-refresh=2 --enable-features=SimplifyHttpsIndicator,WebUIDarkMode,NewExtensionUpdaterService,CloudPrinterHandler,HistoryManipulationIntervention,IntentPicker,LazyFrameLoading,LazyImageLoading,MarkHttpAs,NativeNotifications,OmniboxMaterialDesignWeatherIcons,OmniboxRichEntitySuggestions,OmniboxSpeculativeServiceWorkerStartOnQueryInput,OmniboxSuggestionTransparencyOptions,OmniboxUIExperimentHideSteadyStateUrlPathQueryAndRef,OmniboxUIExperimentShowSuggestionFavicons,ParallelDownloading,SaveEditedPDFForm,ScrollableTabStrip,TabGroups,WebRtcHideLocalIpsWithMdns --disable-features=LookalikeUrlNavigationSuggestionsUI,AutofillServerCommunication,UnifiedConsent,AudioServiceOutOfProcess,AutomaticPasswordGeneration,HappinessTrackingSurveysForDesktop,WebRtcRemoteEventLog --flag-switches-end
Executable Path | /usr/lib/brave-nightly-bin/brave
Profile Path | /home/wolf/.config/BraveSoftware/Brave-Browser/Default
Variations | 2729b628-70ea8f25

Installed via AUR using brave-nightly-bin

Version/Channel Information:

  • Can you reproduce this issue with the current release? Haven't checked
  • Can you reproduce this issue with the beta channel? Haven't checked
  • Can you reproduce this issue with the dev channel? Haven't checked
  • Can you reproduce this issue with the nightly channel? Yes
@rebron
Copy link
Collaborator

rebron commented Sep 17, 2019

Hi @Valinwolf.

If you go into brave://bookmarks/ and move all the bookmarks out of "Other bookmarks" into a different folder so that "Other bookmarks" folder is empty, that hides "Other bookmarks" folder from showing on the Bookmarks bar.

Marking wontfix. I don't think we need another method to hide "Other bookmarks" folder as it's hidden if it's empty.

@Valinwolf
Copy link
Author

Valinwolf commented Sep 17, 2019

The only other folder is the bookmarks bar and there is no option to add a new folder! That means it will be on there, just named something else and grouped elsewhere. How is that a solution???

@rebron
Copy link
Collaborator

rebron commented Sep 17, 2019

@Valinwolf In the right hand corner, there's a menu item that let's you add a new folder.
Screen Shot 2019-09-17 at 3 45 04 PM

It's the bookmarks bar so the expectation is that bookmarks show up there. There's likely an extension you could use to do what you want.

@Valinwolf
Copy link
Author

Valinwolf commented Sep 18, 2019

Screenshot from 2019-09-17 19-22-24
Screenshot from 2019-09-17 19-22-35

That adds the new folder to either the Bookmarks bar or the "Other Bookmarks" folder. If I add it to the bar, that defeats the purpose. If I add it to the Other Bookmarks folder, it also defeats the purpose because to not show it, you must have it empty.

P.S.: Everyone just jumps straight to extensions on this browser from what I have noticed... I don't like them. They bog down the browser and add another vendor you have to trust.

@rebron
Copy link
Collaborator

rebron commented Sep 18, 2019

I'm sure not ideal but you could create another folder in Blogs or Projects and make that your catch all folder instead of "Other bookmarks" to keep things clean.

I see what you're wanting, special casing (which is already a special case) "Other Bookmarks" folder with the option to hide. You want to use Bookmarks but not see most of them and just access them from the address bar via autocomplete? Otherwise, there's no other way to get to those bookmarks outside of the bookmarks manager.

@Valinwolf
Copy link
Author

Yes, that's basically what I'm wanting. Those are the "rarely accessed" bookmarks that I don't want cluttering my bookmarks bar and if I want to open one of them, I generally will either use the autocomplete in the url bar or open the manager. If it was Vivaldi or Firefox, I would access it through the bookmarks menu, since they have the menu and the bar separate. Either way, it is not ideal to use one of my bar folders nor installing an extension. As I mentioned in my last post, I run with as few extensions as possible because, A, I don't trust extensions with permissions like bookmarks or website data without reviewing the code and that becomes a pain, and B, the code performance for extensions suck and the more of them that are installed, the less smooth the browser runs. For some that latter may not be a problem, but for my poor outdated-before-manufactured laptop performance is everything. I had to run Arch because it lagged with Fedora and Ubuntu.

So please, reopen this for consideration. It shouldn't take much to implement - even if it's only available through low level settings. There has to already be an if statement, because it disappears when empty.

@rebron rebron reopened this Sep 18, 2019
@rebron rebron added feature-request priority/P5 Not scheduled. Don't anticipate work on this any time soon. and removed feature-request labels Sep 18, 2019
@rebron
Copy link
Collaborator

rebron commented Sep 18, 2019

Reopening (for a while) but not trivial to implement (there are implications here with sync for example) and we would need to see other users wanting something like this especially since creating another folder (to hold all the bookmarks you don't want to see) in one of your top folders is a perfectly fine workaround.

Personally, I have a folder I labelled "archive" and put all my bookmarks in there.

@MauroNavarro
Copy link

MauroNavarro commented Jan 8, 2020

I have a somehow a similar question: I had to reinstall Windows 10, so I exported my bookmarks to an HTML using the export option. After Windows was reinstalled I imported the HTML bookmarks file but I can't find the "Other bookmarks" folder I had before. Did I lose it when the bookmarks got exported or did I have to specify exporting the "Other ..." folder separately?, which I didn't. Thank you

@mil1i
Copy link

mil1i commented Jan 9, 2020

I believe this is either a new bug, or this request was implemented globally by the brave team.

As @MauroNavarro mentioned above, I also no longer have my 'Other bookmarks' folder on the right hand side. Unlike the original poster, I want to keep my excess bookmarks in a separate folder so I don't have MANY bookmarks on my bar. This is only happening on Brave for me, and not on Google Chrome. Happens on both Windows 10 and macOS.

Brave: Version 1.2.42
Chromium: 79.0.3945.117 (Official Build) (64-bit)

Ideally it would not follow the same format as Google Chrome with the 'Other bookmarks' gigantic folder name and instead follow Mozilla Firefox's overflow bookmarks of a small single icon (See below) pinned on the right-hand side of the bookmarks bar.

image

@bavalpey
Copy link

I believe this is either a new bug, or this request was implemented globally by the brave team.

As @MauroNavarro mentioned above, I also no longer have my 'Other bookmarks' folder on the right hand side. Unlike the original poster, I want to keep my excess bookmarks in a separate folder so I don't have MANY bookmarks on my bar. This is only happening on Brave for me, and not on Google Chrome. Happens on both Windows 10 and macOS.

Brave: Version 1.2.42
Chromium: 79.0.3945.117 (Official Build) (64-bit)

Ideally it would not follow the same format as Google Chrome with the 'Other bookmarks' gigantic folder name and instead follow Mozilla Firefox's overflow bookmarks of a small single icon (See below) pinned on the right-hand side of the bookmarks bar.

image

Same issue happening to me. I did not even realize the 'other bookmarks' portion on the side even existed. I thought it was a Chrome feature that Brave just didn't have.

@D3m3rion
Copy link

Hey, just wanted to let you know that I would also be interested in hiding the "Other Bookmarks" folder.
Other than OP I don't have the possibility to hide them in another folder because I don't have one; my bookmarks bar only consists of direct links.

What I did was to move all my other bookmarks into a folder in the main bookmarks folder, gave it an empty name and moved it completely to the left. Now there is only a folder icon sitting, which also looks good.

Screenshot 2020-04-15 at 20 30 03

@rebron rebron added this to Untriaged backlog in Front End Apr 20, 2020
@rebron rebron moved this from Untriaged backlog to P5 backlog in Front End Apr 24, 2020
@QAthulhu
Copy link

QAthulhu commented Apr 2, 2021

any updates on this? Firefox is the only browser that actually manages bookmarks well

@Valinwolf
Copy link
Author

any updates on this? Firefox is the only browser that actually manages bookmarks well

I find that Vivaldi has a decent bookmark system that actually takes inspiration from Firefox. I got tired of waiting and moved back to Vivaldi. I've bounced from browser to browser looking for the "perfect" one, and I'm never completely satisfied.

@Lyasunder777
Copy link

The Brave browser as well as Microsoft Edge are based on chrome. Unless these browsers leave their the chrome browser foundations are only option is to leave chrome based browsers.

@akash-258
Copy link

I thought all browsers handle bookmarks just like Firefox, so I moved to brave but cannot not show some bookmark folder in bookmark bar. Why is this functionality not implemented in chromium browsers. Was it so absurd to think of something basic like this. Anyway back to Firefox I guess.

@MauroNavarro
Copy link

MauroNavarro commented Oct 5, 2021 via email

@rebron rebron moved this from P5 backlog to In progress in Front End Feb 6, 2024
@brave-builds brave-builds added this to the 1.64.x - Nightly milestone Feb 7, 2024
@rebron rebron moved this from In progress to Completed in Front End Feb 13, 2024
@LaurenWags
Copy link
Member

LaurenWags commented Mar 4, 2024

Verified with

Brave | 1.64.95 Chromium: 122.0.6261.94 (Official Build) beta (x86_64)
-- | --
Revision | 6f4193fbcee7c358ae3684f777faa9f12e52206e
OS | macOS Version 13.6.4 (Build 22G513)

Verified manual test case from brave/brave-core#21918 (comment):

  • Confirmed "All Bookmarks" option only displays on the Bookmarks Toolbar if there is at least one bookmark in "Other Bookmarks"
  • Confirmed "Show All Bookmarks Button" is checked by default
  • Confirmed able to uncheck/unselect "Show All Bookmarks Button" and the "All Bookmarks" option is removed from the Bookmarks Toolbar
  • Confirmed able to re-check/select "Show All Bookmarks Button" and the "All Bookmarks" option is re-added to the Bookmarks Toolbar
  • Confirmed selection is persisted across re-launch
Example Example
1 2

Encountered the following issues while testing:

@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 4, 2024
@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 5, 2024
@rebron rebron removed this from Completed in Front End Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.