Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The ' clear all cookies and site data when you quit brave' toggle reverts back to default after closing the window . #6119

Closed
ShockRocky opened this issue Sep 22, 2019 · 6 comments · Fixed by brave/brave-core#3785
Closed

The ' clear all cookies and site data when you quit brave' toggle reverts back to default after closing the window . #6119

ShockRocky opened this issue Sep 22, 2019 · 6 comments · Fixed by brave/brave-core#3785
Assignees
@mkarolin
Labels
bug feature/global-settings Settings at browser level independent of shields settings priority/P2 A bad problem. We might uplift this to the next planned release. privacy QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.0.0 - Release

Comments

@ShockRocky
Copy link

ShockRocky commented Sep 22, 2019 •
edited by kjozwiak

Description

The ' clear all cookies and site data when you quit brave' toggle when turned on in chrome://settings/content/cookies, revert back to it's default state[off] when the window is closed.

Steps to Reproduce

  1. Go to chrome://settings/content/cookies
  2. Toggle on 'clear all cookies and site data when you quit brave', exit the tab.
  3. The toggle is back to its off state, thus not persisting with the user's decision.

Reproduces how often:

Encountered the bug on a fresh install of brave[ Version 0.68.139 Chromium: 77.0.3865.90] on a windows 10 laptop, also persists on a fresh profile .

Brave version (brave://version info)

Brave | 0.68.139 Chromium: 77.0.3865.90 (Official Build) (64-bit)

OS | Windows 10 OS Version 1903 (Build 18362.356)

Version/Channel Information:

Haven't tried to reproduce the issue on other builds of the browser, except the aforementioned one .

  • Can you reproduce this issue with the current release?
    Yes .
  • Can you reproduce this issue with the beta channel?
    Haven't tried.
  • Can you reproduce this issue with the dev channel?
    Haven't tried.
  • Can you reproduce this issue with the nightly channel?
    Haven't tried.

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
    No.
  • Does the issue resolve itself when disabling Brave Rewards?
    No.
  • Is the issue reproducible on the latest version of Chrome?
    I don't use chrome.
@kojid0
Copy link

kojid0 commented Oct 1, 2019 •
edited

same here. Hope this privacy bug gets fixed soon.
Version 0.68.142 Chromium: 77.0.3865.90 (Official Build) (64-bit) // Windows 10 OS Version 1809 (Build 17763.737)

@bsclifton
Copy link
Member

bsclifton commented Oct 2, 2019 •
edited

cc: @mkarolin did this regress with Chromium 77?

@bsclifton bsclifton added bug feature/global-settings Settings at browser level independent of shields settings needs-investigation A bug not 100% confirmed/fixed labels Oct 2, 2019
@bsclifton bsclifton added this to Untriaged Backlog in Security & Privacy via automation Oct 2, 2019
@bsclifton bsclifton mentioned this issue Oct 2, 2019
Closed
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Oct 4, 2019
@Brave-Matt
Copy link

Chiming in here with a few notes -- Recently helped several users in these threads:
https://community.brave.com/t/clear-cookies-and-site-data-when-you-quit-brave-deactivates-itself/85751/20
https://community.brave.com/t/clear-cookies-and-site-data-when-you-quit-brave-deactivates-itself-2/87394

A bit of clarity surrounding this behavior:

  • As the title of this issue suggests, the Clear cookies and site data when you quit Brave toggle resets itself after Brave is relaunched.
    image

  • When/if that toggle works, users are able to add site exceptions (brave://settings/content --> Allow) such that they are not cleared after quitting the browser.

  • If users instead use the [On exit] window (brave://settings/clearBrowserData --> [On exit]), data is cleared on exit and the data checked to be cleared is not reset. However, this function clears all browsing data, regardless of whether or not there are exceptions added.
    image

Suggestion:
I don't see any reason we need to have both of these options. Seems to lead to a lot of confusion and produces "mixed" results because of it. Instead, we should remove the toggle in brave://settings/content and rework the [On exit] option so that it doesn't clear or alter manually added (or blocked) site exceptions.

cc @rebron @bsclifton

@rebron rebron removed this from Untriaged Backlog in Security & Privacy Oct 16, 2019
@rebron rebron added this to P1 & P2 Backlog in General Oct 16, 2019
mkarolin added a commit to brave/brave-core that referenced this issue Oct 23, 2019
@mkarolin
Fixes clear cookies on exit toggle.
ff23fbc 
Fixes brave/brave-browser#6119

Account for CONTENT_SETTING_SESSION_ONLY as a possibility for the
default cookie setting in preferences - do not override it with
CONTENT_SETTING_ALLOW if it's already set.
mkarolin added a commit to brave/brave-core that referenced this issue Oct 23, 2019
@mkarolin
Fixes clear cookies on exit toggle.
240588b 
Fixes brave/brave-browser#6119

Account for CONTENT_SETTING_SESSION_ONLY as a possibility for the
default cookie setting in preferences - do not override it with
CONTENT_SETTING_ALLOW if it's already set.
mkarolin added a commit to brave/brave-core that referenced this issue Oct 23, 2019
@mkarolin
Fixes clear cookies on exit toggle.
1b0cac8 
Fixes brave/brave-browser#6119

Account for CONTENT_SETTING_SESSION_ONLY as a possibility for the
default cookie setting in preferences - do not override it with
CONTENT_SETTING_ALLOW if it's already set.

Added browser test CookiePrefServiceTest.CookieControlType_Preference to
test Shields cookie setting change when preference setting changes
and in reverse.
@mkarolin mkarolin mentioned this issue Oct 23, 2019
Merged
32 tasks
mkarolin added a commit to brave/brave-core that referenced this issue Oct 23, 2019
@mkarolin
Fixes clear cookies on exit toggle.
92589a6 
Fixes brave/brave-browser#6119

Account for CONTENT_SETTING_SESSION_ONLY as a possibility for the
default cookie setting in preferences - do not override it with
CONTENT_SETTING_ALLOW if it's already set.

Added browser test CookiePrefServiceTest.CookieControlType_Preference to
test Shields cookie setting change when preference setting changes
and in reverse.
mkarolin added a commit to brave/brave-core that referenced this issue Oct 23, 2019
@mkarolin
Fixes clear cookies on exit toggle.
130fed5 
Fixes brave/brave-browser#6119

Account for CONTENT_SETTING_SESSION_ONLY as a possibility for the
default cookie setting in preferences - do not override it with
CONTENT_SETTING_ALLOW if it's already set.

Added browser test CookiePrefServiceTest.CookieControlType_Preference to
test Shields cookie setting change when preference setting changes
and in reverse.
mkarolin added a commit to brave/brave-core that referenced this issue Oct 24, 2019
@mkarolin
Fixes clear cookies on exit toggle.
e017f5f 
Fixes brave/brave-browser#6119

Account for CONTENT_SETTING_SESSION_ONLY as a possibility for the
default cookie setting in preferences - do not override it with
CONTENT_SETTING_ALLOW if it's already set.

Added browser test CookiePrefServiceTest.CookieControlType_Preference to
test Shields cookie setting change when preference setting changes
and in reverse.
@rebron rebron added 1.0 and removed 1.0-suggestion labels Oct 29, 2019
@bsclifton bsclifton added release-notes/include and removed needs-investigation A bug not 100% confirmed/fixed labels Oct 30, 2019
General automation moved this from P1 & P2 Backlog to Completed Oct 30, 2019
@bsclifton bsclifton added this to the 0.73.x - Nightly milestone Oct 30, 2019
@brave-builds brave-builds mentioned this issue Oct 30, 2019
Merged
4 tasks
@brave-builds brave-builds mentioned this issue Oct 30, 2019
Merged
4 tasks
@LaurenWags
Copy link
Member

QA/Blocked until we get a new build. Will be available in 0.71.107` and above.

@LaurenWags
Copy link
Member

Removing QA/Blocked label as build 0.71.107 is available.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 4, 2019 •
edited by LaurenWags

Verification passed on

Brave 0.71.108 Chromium: 78.0.3904.87 (Official Build) beta (64-bit)
Revision 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • The original issue is reproduced in both 0.68.142 and 0.70.122
  • Verified the STR from the description, verified on both clean and upgraded profile
  • Verified that the cookies are cleared when turn ON the clear all cookies and site data when you quit brave option under chrome://settings/content/cookies and quit the browser
  • Verified that the state of clear all cookies and site data when you quit brave option is ON after the browser restart
  • Verified the clear Cookies and other site data on exit works as expected

Verification passed on

Brave 0.71.111 Chromium: 78.0.3904.87 (Official Build) (64-bit)
Revision 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS Ubuntu 18.04 LTS
  • Verified the STR from the description, verified on both clean and upgraded profile
  • Verified that the cookies are cleared when turn ON the clear all cookies and site data when you quit brave option under chrome://settings/content/cookies and quit the browser
  • Verified that the state of clear all cookies and site data when you quit brave option is ON after the browser restart

Verification passed with

Brave 0.71.111 Chromium: 78.0.3904.87 (Official Build) (64-bit)
Revision 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS macOS Version 10.13.6 (Build 17G5019)
  • Verified the STR from the description
  • Verified that the cookies are cleared when turn ON the clear all cookies and site data when you quit brave option under chrome://settings/content/cookies and quit the browser
  • Verified that the state of clear all cookies and site data when you quit brave option is ON after the browser restart
  • Verified the clear Cookies and other site data on exit works as expected
  • Verified you are able to toggle this option OFF and cookies are not cleared on exit.

@kjozwiak kjozwiak mentioned this issue Nov 12, 2019
Closed
@rebron rebron removed this from Completed in General Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
bug feature/global-settings Settings at browser level independent of shields settings priority/P2 A bad problem. We might uplift this to the next planned release. privacy QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.0.0 - Release
Development

Successfully merging a pull request may close this issue.

Fixes clear cookies on exit toggle. brave/brave-core
9 participants
@Brave-Matt @bsclifton @rebron @kojid0 @LaurenWags @btlechowski @GeetaSarvadnya @mkarolin @ShockRocky