Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmark import/export on Android #6378

Closed
srirambv opened this issue Oct 9, 2019 · 27 comments · Fixed by brave/brave-core#17821
Closed

Bookmark import/export on Android #6378

srirambv opened this issue Oct 9, 2019 · 27 comments · Fixed by brave/brave-core#17821
Assignees
Labels
Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected feature/bookmarks feature/importer feature-request OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android 8+ QA/Test-All-Platforms QA/Yes release-notes/include

Comments

@srirambv
Copy link
Contributor

srirambv commented Oct 9, 2019

Description

Bookmark import/export on Android is one of the most frequently requested feature that is missing. This is to bridge feature between desktop and mobile. It would be good to have this feature done for the first release or on the second. Having this feature allows users to export bookmarks and reinstall brave if they wish to.

Miscellaneous Information:

cc: @anthonypkeane @brave/android @bridiver

@srirambv
Copy link
Contributor Author

srirambv commented Oct 19, 2019

@srirambv
Copy link
Contributor Author

+1 request from https://community.brave.com/t/bookmark-backup-support-missing/88224/2

@srirambv srirambv added this to To Do in Android General via automation Jan 4, 2020
@drusalan
Copy link

drusalan commented Jan 9, 2020

So in other words this will likely never be an option. Brave is just not ready to be taken seriously.

@srirambv srirambv added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jan 9, 2020
@bridiver
Copy link
Contributor

bridiver commented Jan 9, 2020

So in other words this will likely never be an option. Brave is just not ready to be taken seriously.

What is it about a ticket being opened by a Brave employee to fix this issue makes you think this is not likely to ever be an option? The beta version of the android app ported to brave-core isn't even available yet.

@drusalan
Copy link

@bridiver Probably due to the fact this has been an issue or request since 2017 from another thread/issue (whatever). I don't make a habit of trolling github. I have been however, patiently waiting over 1.5 years while using this browser, alot. How long should I keep waiting my dears, until I just use Firefox? I mean Brave is terrible on MXLinux which I use on desktop, but that's another story. In the meantime, I and others are devising slow workaround methods to manage bookmarks. Some have given up and moved on. These issues lead me to believe they/you/whomever aren't serious or don't care to implement this feature. Forgive me if I'm overlooking something obvious that would reason not to have this feature on browsers since like 1987. Therefore, I can't take Brave seriously until this. I appreciate you enjoy working on your project and maybe I'm sorry I feel this way. I guess now I need to apologize that I may have hurt your/his/their feelings about this issue. I won't.

@bridiver
Copy link
Contributor

bridiver commented Jan 10, 2020 via email

@Dreamulet
Copy link

Dreamulet commented Jan 12, 2020

Came upon this thread when I was searching how to export my bookmarks from Brave which I just downloaded (and had thought I should save my bookmarks while I'm at it). I couldn't find the answer, so I went back over to Chrome to save them and thought I should try the same location for Brave and it was! So just click on the 3 lines for drop down menu in the upper right hand corner, click bookmarks>Bookmark manager. Then click the 3 dots on the right top area and there it is! import and export along with a few other things. Y'all probably figured this out already. But I wanted to post this comment for anyone new coming over as I still didn't quite see this answer. Hope this helps!

@srirambv
Copy link
Contributor Author

@Dreamulet your steps are for Desktop. This issue is for Android browser where we currently don't have import/export option

@Dreamulet
Copy link

@Dreamulet your steps are for Desktop. This issue is for Android browser where we currently don't have import/export option

Oh ok, thanks for the clarification. (I did wonder that, after I posted of course :)

@sdkane
Copy link

sdkane commented Mar 19, 2020

Is there a method to manually extract the bookmarks using adb? This could work as an immediate holdover.

@sigfreud
Copy link

sigfreud commented Apr 30, 2020

If we had no intentions of implementing this we would close it as "won't fix", not open a new ticket for brave-core. There are a limited number of resources to implement features and things have to be prioritized. If enough users were asking for this I guarantee the priority would be bumped up. If you don't think other browsers like Chrome have very old tickets that a lot of users are asking for then you haven't spent enough time looking at them. We're also happy to look at contributions for this functionality.

Not enough users are asking for this feature because nobody is using brave. At least, to the last users, give us a way to take with us our precious bookmarks, please.

@listsatjanirnet
Copy link

No one is asking for a special implementation. Just point out where and how we can extract our bookmarks from Brave android app as we can retrive bookmarks until Sync is fixed. I went nearly 4 months of saving bookmarks on my phone before I reailzed they were no longer being synced. I have way too many to be able to sort out old ones from whats new on my phone b4 recording them. There are more of u out here that just need some guidance as to how to extra them from the phone.

@grossetti
Copy link

This would be great to have as a workaround for the sync issue; I am sure it is quicker to implement than it is to fix sync :).

I have a dying phone and I realized sync no longer works (even after installing the latest versions on Android and PC and re-enabling sync). I just want to be able to export my bookmarks so this would be great. At this point I am also open to workarounds.

Thanks!

@artella-coding
Copy link

With large numbers of bookmarks I have found sync slow and sometimes unreliable. It would be great if we could either export or atleast access the bookmark file on android (right now I think it is located in the data folder, which can only be accessed on a rooted phone). I agree with @grossetti that all this must be easier to implement than ironing out all the issues with sync, which people have been working on for a long time. Thanks

@k-kruglov
Copy link

Please, make it happen. There's no sync, at least let us import/export bookmarks on android.

@grossetti
Copy link

Sync is starting to work for me, please see here:
https://community.brave.com/t/how-does-brave-sync-work/122117/8

@Poopooracoocoo
Copy link

Bromite has a patch for this: https://github.com/bromite/bromite/blob/master/build/patches/Add-bookmark-import-export-actions.patch

This was referenced Jun 6, 2020
@NM-E
Copy link

NM-E commented Aug 3, 2020

Very surprised to see there is no offline bookmark/import export option in any major android browsers except Bromite...

@brave brave deleted a comment from p3yot3 Oct 26, 2021
@brave brave deleted a comment from hiredgunhouse Oct 26, 2021
@brave brave deleted a comment from drusalan Oct 26, 2021
@brave brave locked and limited conversation to collaborators Oct 26, 2021
@SergeyZhukovsky
Copy link
Member

Just to reiterate so everyone is on the same page and I hope agreed with a current statement:

  1. Brave on Android cannot just pull bookmarks from Chrome on Android. Why? As they don't store them on a device, they don't provide any export on mobile for that from a browser.
  2. It's possible to export to a file from Chrome on a laptop/desktop.
  3. It's possible to export to a file using that service https://takeout.google.com/settings/takeout?pli=1. Where you can pick Chrome and pick bookmarks. You have to be signed in with your gmail account there.

We can do a functionality to import from the provided file. Is that what everyone wants?

@timchilds timchilds self-assigned this Oct 26, 2022
@brave brave unlocked this conversation Nov 14, 2022
@timchilds
Copy link

@timchilds timchilds removed their assignment Nov 14, 2022
@deeppandya deeppandya assigned timchilds and jenn-rhim and unassigned timchilds Nov 16, 2022
@timchilds
Copy link

timchilds commented Jan 27, 2023

@tapanmodh tapanmodh self-assigned this Apr 5, 2023
Android General automation moved this from P3 to Done/Closed May 13, 2023
@brave-builds brave-builds added this to the 1.53.x - Nightly milestone May 13, 2023
@kjozwiak kjozwiak added QA/Test-All-Platforms Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected labels Jun 13, 2023
@hffvld
Copy link
Contributor

hffvld commented Jun 20, 2023

Verified on Pixel 2 XL, Pixel 7 and Galaxy Tab S8 using version(s):

Device/OS: 
- Pixel 2 XL [taimen-user  8.1.0 OPM2.171026.006.H1 release-keys]
- Pixel 7 [panther_beta-user 14 UPB3.230519.014 release-keys]
- Galaxy Tab S8 [gts8wifixx-user 13 TP1A.220624.014 release-keys]
Brave build: 1.53.100
Chromium: 114.0.5735.133 (Official Build) beta (64-bit)
Revision: fbfa2ce68d01b2201d8c667c2e73f648a61c4f4a-refs/branch-heads/5735@{#1270}

Android 8 (Phone)
Export bookmarks. Create HTML file on Android - PASS

STEPS:

  1. Launch Brave 1.53.x
  2. Open any website, for example, www.youtube.com
  3. Add the website to the bookmarks by tapping Bookmark thumbnail
  4. Three-dot menu > Bookmarks
  5. Three-dot menu in the top right corner on the Bookmarks screen > Tap Export bookmarks
  6. Observe pop-up Bookmarks exported successfully. confirmation notification

ACTUAL RESULTS:

  • Verified that the Export bookmarks feature is working and Bookmarks exported successfully. confirmation is shown
  • Verified that the HTML file is created in Downloads successfully
1 2 3
1 2 3
Export Brave Desktop bookmarks HTML file to Android device - PASS

PRECONDITIONS:

  • Bookmarks HTML file already created in Brave on Desktop device and shared with Android device

STEPS:

  1. Launch Brave > Three-dot menu > Bookmarks
  2. Three-dot menu in the top right corner > Tap Import bookmarks
  3. Choose shared Bookmarks HTML file > Verify

ACTUAL RESULTS:

  • Verified that Bookmarks HTML file from Brave on Desktop can be used on Android to import bookmarks
  • Verified that imported bookmarks can be opened
timestamp_13-24-33_13-25-03.mp4
Export Chrome Desktop bookmarks HTML file to Android device - PASS

PRECONDITIONS:

  • Bookmarks HTML file already created in Chrome on Desktop device and shared with Android device

STEPS:

  1. Launch Brave > Three-dot menu > Bookmarks
  2. Three-dot menu in the top right corner > Tap Import bookmarks
  3. Choose shared Bookmarks HTML file > Verify

ACTUAL RESULTS:

  • Verified that Bookmarks HTML file from Chrome on Desktop can be used on Android to import bookmarks
  • Verified that imported bookmarks can be opened
timestamp_13-26-17_13-26-32.mp4
Export Firefox Desktop bookmarks HTML file to Android device - PASS

PRECONDITIONS:

  • Bookmarks HTML file already created in Firefox on Desktop device and shared with Android device

STEPS:

  1. Launch Brave > Three-dot menu > Bookmarks
  2. Three-dot menu in the top right corner > Tap Import bookmarks
  3. Choose shared Bookmarks HTML file > Verify

ACTUAL RESULTS:

  • Verified that Bookmarks HTML file from Firefox on Desktop can be used on Android to import bookmarks
  • Verified that imported bookmarks can be opened
timestamp_13-27-10_13-27-25.mp4
Export Brave iOS bookmarks HTML file to Android device - PASS

PRECONDITIONS:

  • Bookmarks HTML file already created in Brave on iOS device and shared with Android device

STEPS:

  1. Launch Brave > Three-dot menu > Bookmarks
  2. Three-dot menu in the top right corner > Tap Import bookmarks
  3. Choose shared Bookmarks HTML file > Verify

ACTUAL RESULTS:

  • Verified that Bookmarks HTML file from Brave on iOS can be used on Android to import bookmarks
  • Verified that imported bookmarks can be opened
timestamp_13-27-59_13-28-14.mp4
Import Android bookmarks HTML file to Android device - PASS

PRECONDITIONS:

  • Bookmarks HTML file already created on an Android device and shared with another Android device (or just reuse the same Android device)

STEPS:

  1. To test you can share the Bookmarks HTML file with another Android device or use the same device and remove all saved bookmarks first
  2. Launch Brave > Three-dot menu > Bookmarks
  3. Three-dot menu in the top right corner > Tap Import bookmarks
  4. Choose saved Bookmarks HTML file > Verify

ACTUAL RESULTS:

  • Verified that Bookmarks HTML file from Android can be used on another or the same Android device to import bookmarks
  • Verified that imported bookmarks can be opened
  • Verified that only HTML files can be used to import bookmarks
1 2 3
1 2 3
Android 13 (Tab)
Export bookmarks. Create HTML file on Android - PASS

STEPS:

  1. Launch Brave 1.53.x
  2. Open any website, for example, www.youtube.com
  3. Add the website to the bookmarks by tapping Bookmark thumbnail
  4. Three-dot menu > Bookmarks
  5. Three-dot menu in the top right corner on the Bookmarks screen > Tap Export bookmarks
  6. Observe pop-up Bookmarks exported successfully. confirmation notification

ACTUAL RESULTS:

  • Verified that the Export bookmarks feature is working and Bookmarks exported successfully. confirmation is shown
  • Verified that the HTML file is created in Downloads successfully
1 2 3
1 2 3
41 5 6
1 2 3
Export Brave Desktop bookmarks HTML file to Android device - PASS

PRECONDITIONS:

  • Bookmarks HTML file already created in Brave on Desktop device and shared with Android device

STEPS:

  1. Launch Brave > Three-dot menu > Bookmarks
  2. Three-dot menu in the top right corner > Tap Import bookmarks
  3. Choose shared Bookmarks HTML file > Verify

ACTUAL RESULTS:

  • Verified that Bookmarks HTML file from Brave on Desktop can be used on Android to import bookmarks
  • Verified that imported bookmarks can be opened
timestamp_13-47-39_13-48-00.mp4
Export Chrome Desktop bookmarks HTML file to Android device - PASS

PRECONDITIONS:

  • Bookmarks HTML file already created in Chrome on Desktop device and shared with Android device

STEPS:

  1. Launch Brave > Three-dot menu > Bookmarks
  2. Three-dot menu in the top right corner > Tap Import bookmarks
  3. Choose shared Bookmarks HTML file > Verify

ACTUAL RESULTS:

  • Verified that Bookmarks HTML file from Chrome on Desktop can be used on Android to import bookmarks
  • Verified that imported bookmarks can be opened
timestamp_13-48-41_13-48-52.mp4
Export Firefox Desktop bookmarks HTML file to Android device - PASS

PRECONDITIONS:

  • Bookmarks HTML file already created in Firefox on Desktop device and shared with Android device

STEPS:

  1. Launch Brave > Three-dot menu > Bookmarks
  2. Three-dot menu in the top right corner > Tap Import bookmarks
  3. Choose shared Bookmarks HTML file > Verify

ACTUAL RESULTS:

  • Verified that Bookmarks HTML file from Firefox on Desktop can be used on Android to import bookmarks
  • Verified that imported bookmarks can be opened
timestamp_13-49-27_13-49-39.mp4
Export Brave iOS bookmarks HTML file to Android device - PASS

PRECONDITIONS:

  • Bookmarks HTML file already created in Brave on iOS device and shared with Android device

STEPS:

  1. Launch Brave > Three-dot menu > Bookmarks
  2. Three-dot menu in the top right corner > Tap Import bookmarks
  3. Choose shared Bookmarks HTML file > Verify

ACTUAL RESULTS:

  • Verified that Bookmarks HTML file from Brave on iOS can be used on Android to import bookmarks
  • Verified that imported bookmarks can be opened
timestamp_13-49-57_13-50-08.mp4
Import Android bookmarks HTML file to Android device - PASS

PRECONDITIONS:

  • Bookmarks HTML file already created on an Android device and shared with another Android device (or just reuse the same Android device)

STEPS:

  1. To test you can share the Bookmarks HTML file with another Android device or use the same device and remove all saved bookmarks first
  2. Launch Brave > Three-dot menu > Bookmarks
  3. Three-dot menu in the top right corner > Tap Import bookmarks
  4. Choose saved Bookmarks HTML file > Verify

ACTUAL RESULTS:

  • Verified that Bookmarks HTML file from Android can be used on another or the same Android device to import bookmarks
  • Verified that imported bookmarks can be opened
  • Verified that only HTML files can be used to import bookmarks
1 2 3
1 2 3
Android 14 (Phone)
Export bookmarks. Create HTML file on Android - PASS

STEPS:

  1. Launch Brave 1.53.x
  2. Open any website, for example, www.youtube.com
  3. Add the website to the bookmarks by tapping Bookmark thumbnail
  4. Three-dot menu > Bookmarks
  5. Three-dot menu in the top right corner on the Bookmarks screen > Tap Export bookmarks
  6. Observe pop-up Bookmarks exported successfully. confirmation notification

ACTUAL RESULTS:

  • Verified that the Export bookmarks feature is working and Bookmarks exported successfully. confirmation is shown
  • Verified that the HTML file is created in Downloads successfully
1 2 3
1 2 3
4 5 6
1 2 3
Export Brave Desktop bookmarks HTML file to Android device - PASS

PRECONDITIONS:

  • Bookmarks HTML file already created in Brave on Desktop device and shared with Android device

STEPS:

  1. Launch Brave > Three-dot menu > Bookmarks
  2. Three-dot menu in the top right corner > Tap Import bookmarks
  3. Choose shared Bookmarks HTML file > Verify

ACTUAL RESULTS:

  • Verified that Bookmarks HTML file from Brave on Desktop can be used on Android to import bookmarks
  • Verified that imported bookmarks can be opened
timestamp_12-32-48_12-33-28.mp4
Export Chrome Desktop bookmarks HTML file to Android device - PASS

PRECONDITIONS:

  • Bookmarks HTML file already created in Chrome on Desktop device and shared with Android device

STEPS:

  1. Launch Brave > Three-dot menu > Bookmarks
  2. Three-dot menu in the top right corner > Tap Import bookmarks
  3. Choose shared Bookmarks HTML file > Verify

ACTUAL RESULTS:

  • Verified that Bookmarks HTML file from Chrome on Desktop can be used on Android to import bookmarks
  • Verified that imported bookmarks can be opened
timestamp_12-35-26_12-35-47.mp4
Export Firefox Desktop bookmarks HTML file to Android device - PASS

PRECONDITIONS:

  • Bookmarks HTML file already created in Firefox on Desktop device and shared with Android device

STEPS:

  1. Launch Brave > Three-dot menu > Bookmarks
  2. Three-dot menu in the top right corner > Tap Import bookmarks
  3. Choose shared Bookmarks HTML file > Verify

ACTUAL RESULTS:

  • Verified that Bookmarks HTML file from Firefox on Desktop can be used on Android to import bookmarks
  • Verified that imported bookmarks can be opened
timestamp_12-37-28_12-37-52.mp4
Export Brave iOS bookmarks HTML file to Android device - PASS

PRECONDITIONS:

  • Bookmarks HTML file already created in Brave on iOS device and shared with Android device

STEPS:

  1. Launch Brave > Three-dot menu > Bookmarks
  2. Three-dot menu in the top right corner > Tap Import bookmarks
  3. Choose shared Bookmarks HTML file > Verify

ACTUAL RESULTS:

  • Verified that Bookmarks HTML file from Brave on iOS can be used on Android to import bookmarks
  • Verified that imported bookmarks can be opened
timestamp_12-50-57_12-51-21.mp4
Import Android bookmarks HTML file to Android device - PASS

PRECONDITIONS:

  • Bookmarks HTML file already created on an Android device and shared with another Android device (or just reuse the same Android device)

STEPS:

  1. To test you can share the Bookmarks HTML file with another Android device or use the same device and remove all saved bookmarks first
  2. Launch Brave > Three-dot menu > Bookmarks
  3. Three-dot menu in the top right corner > Tap Import bookmarks
  4. Choose saved Bookmarks HTML file > Verify

ACTUAL RESULTS:

  • Verified that Bookmarks HTML file from Android can be used on another or the same Android device to import bookmarks
  • Verified that imported bookmarks can be opened
  • Verified that only HTML files can be used to import bookmarks
1 2 3
1 2 3
4 5 6
1 2 3
timestamp_12-02-22_12-02-41.mp4
Import Android bookmarks HTML file to iOS device - PASS

PRECONDITIONS:

  • Bookmarks HTML file already created on Android device and shared with iOS device

STEPS:

  1. Launch Brave on an iOS device
  2. Go to Bookmarks > Tap Import bookmarks
  3. Choose shared HTML file > Verify

ACTUAL RESULTS:

  • Verified that Bookmarks HTML file from Android can be used on iOS to import bookmarks
  • Verified that imported bookmarks can be opened
iOS.bookmark.export.from.Android.mov
Import Android bookmarks HTML file to a Desktop device - PASS

PRECONDITIONS:

  • Bookmarks HTML file already created on Android device and shared with Desktop device

STEPS:

  1. Launch Brave on a Desktop device
  2. Go to Bookmarks > Tap Import bookmarks
  3. Choose shared HTML file > Verify

ACTUAL RESULTS:

  • Verified that Bookmarks HTML file from Android can be used on Desktop to import bookmarks
  • Verified that imported bookmarks can be opened
Screen.Recording.2023-06-20.at.11.30.17.mov

Filed l10n issues #31176 and #31183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected feature/bookmarks feature/importer feature-request OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android 8+ QA/Test-All-Platforms QA/Yes release-notes/include
Projects
Android General
  
Done/Closed
Development

Successfully merging a pull request may close this issue.