New Sync v2 UI wiring #9241

jsecretan · 2020-04-15T18:27:03Z

TODO

Initial "Start using Sync"
- should change to "manage your sync'd devices" after setup
Sync Setup dialog
- images
- 'mobile' QR code
- should navigate to "Sync Manager" screen after starting
Sync Manager
- "Leave Sync Chain" should confirm first
- Device List
- Sync Settings list

Description

Because of the way that sync functionality is currently loaded as a component with react UI we cannot directly reuse the configuration interface for sync. Because of that and in order to more seamlessly integration sync v2 configuration, we need to rework and rewire the current sync settings UI.

Primary changes are as follows:

The link to sync from settings can now link directly to it's settings page ("Start Using Sync" before configured, "Manage your sync'd devices" once setup)
The join process should have the same flow as v1
There is a new list of sync devices, but they should now be wired into the Chromium sync records corresponding to those devices. You should still be able to "Leave Sync Chain" for your device, which should first remove the current device's sync record, before disabling sync. However, you can no longer remove other devices from the sync chain ("Remove" column goes away, and please ignore the "X"s currently in the mockup).

iefremov · 2020-04-16T17:43:19Z

@jsecretan

The link to sync from settings

which link?..

on the first picture, what happens if I choose "Computer"?

rebron · 2020-04-16T17:55:30Z

@iefremov it should show the screen above but with the actual sync words

rebron · 2020-04-16T18:00:26Z

For link should be brave://sync to redirect to brave://settings/braveSync.

The two urls for sync will be:
brave://settings/braveSync
brave://settings/braveSync/setup

cc: @darkdh @bradleyrichter

madhums · 2020-04-16T20:53:54Z

Bookmarks were the only ones that were being synced but that doesn't work anymore since a month+

Any ETA on when sync will be enabled again?

akash07k · 2020-04-27T15:19:33Z

Yes, asking for the same. any ETAs when we can expect the enabled sync?

frankgraave · 2020-04-29T10:01:18Z

I used Brave in its early stages and I liked it already very much. Although I switched back to Chrome for some bug at that time. I went back to Brave a couple of weeks ago and I LOVE it, the only issue for me is that sync is not available as I recently found out and lost all my bookmarks after a reinstall. So therefore I'm also curious if there is an ETA on the Sync feature.

ParaplegicRacehorse · 2020-05-01T19:15:05Z

Sync and isolation features (like firefox multi-account containers) are the two sticking points preventing me from making Brave my default browser. Without both of these, Brave will remain a third-choice tool after FF and links (yes. a text-mode browser currently beats out Brave in preference hierarchy).

So. I don't actually see any recent commit history of significance regarding sync, even if I scan across branches (a branch pruning is long past-due.) Is it actively being worked on, per the Reddit post, last month, claiming it to be "top priority?"

HeyITGuyFixIt · 2020-05-02T11:47:36Z

@ParaplegicRacehorse check the roadmap https://github.com/brave/brave-browser/wiki/Roadmap#q2-2020-april---june It's at the top of the list for this quarter.

akash07k · 2020-05-02T12:34:18Z

Oh, means end of june. :( that too is not sure. :(

…

On 5/2/20, Christian Sirolli ***@***.***> wrote: @ParaplegicRacehorse check the roadmap https://github.com/brave/brave-browser/wiki/Roadmap#q2-2020-april---june It's at the top of the list for this quarter. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: #9241 (comment)

ParaplegicRacehorse · 2020-05-02T17:09:37Z

@ParaplegicRacehorse check the roadmap https://github.com/brave/brave-browser/wiki/Roadmap#q2-2020-april---june It's at the top of the list for this quarter.

on the Roadmap, and receiving attention-currency from devs are not the same. As I previously mentioned, the announcement to Reddit is almost a month old (how long has this item been in this place on the Roadmap?) and has received zero commits. The quarter is 30% over...

Look, I'm okay keeping Brave around as my 3rd-choice browser. I really like the ideals and it would be nice to shift it to 2nd or 1st preference position.

Anyway, what are the particular difficulties being experienced with sync? Is it wallet integration? Because, frankly, that's the easy one to sort out.

NejcZdovc · 2020-05-02T18:13:21Z

@ParaplegicRacehorse you can track sync core work here brave/brave-core#5294

shivashranz · 2020-05-19T12:26:54Z

Has this part of the code pushed to the beta builds?

akash07k · 2020-05-19T12:55:36Z

I think no

…

On 5/19/20, shivashranz ***@***.***> wrote: Has this part of the code pushed to the beta builds? -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: #9241 (comment)

jsecretan · 2020-05-22T11:49:41Z

No, not just yet, hoping to merge down into nightly in the next couple of weeks.

akash07k · 2020-05-22T12:10:51Z

Please let us know when it gets merged

…

On 5/22/20, jsecretan ***@***.***> wrote: No, not just yet, hoping to merge down into nightly in the next couple of weeks. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: #9241 (comment)

galenballew · 2020-05-27T12:28:26Z

Hello, I recently started using Brave and I've been very pleased! However, I regularly on 3 different devices and 4 different OS. Not having Sync is...not good. But you know this! Keep up the great work - this is a really fantastic browser and I'm looking forward to evangelizing it when it's ready.

joel-g · 2020-06-02T01:44:57Z

I'm dying to start using brave again the moment password syncing works. Subscribed!

akash07k · 2020-06-05T11:45:20Z

Finally I switched to Firefox. far better. very nice sync implementation as well as better than chrome.

…

On 6/5/20, Paul Jenkins ***@***.***> wrote: > Any recommend a cross plat and cross browser bookmark only syncing service > for the meantime? try https://www.xbrowsersync.org/- working for me pretty well (and integrates with other desktop browsers, mobile ymmv) -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: #9241 (comment)

KhimairaCrypto · 2020-06-06T11:13:04Z

Finally I switched to Firefox. far better. very nice sync implementation as well as better than chrome.
…
On 6/5/20, Paul Jenkins @.***> wrote: > Any recommend a cross plat and cross browser bookmark only syncing service > for the meantime? try https://www.xbrowsersync.org/- working for me pretty well (and integrates with other desktop browsers, mobile ymmv) -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: #9241 (comment)

Agree! The sync side, just works and it sync more than just the bookmarks. Are you guys are going to extend the sync functionality as part of an additional ticket?

artella-coding · 2020-06-06T18:05:53Z

It would also be nice to have import/export from/to file for the Android Browser (#6378). In Sync v1 about 130-170 bookmarks are synced every 80 seconds, which is quite slow (especially if you have a large number of bookmarks). I presume Sync v2 will be roughly the same speed.

jsecretan · 2020-06-08T13:09:37Z

Thanks @artella-coding, hoping that this will be faster but the import/export is probably a good idea in any case. We'll have a better sense of speed for everybody over the next couple of weeks.

jsecretan · 2020-06-08T13:10:24Z

And @KhimairaCrypto we trying to get this deployed with most of the sync types available on desktop/Android, and they'll slowly work their way to iOS. So if all goes well, you'll have more than just bookmarks.

szaimen · 2020-06-11T23:04:37Z

🎉

oraculum · 2020-06-12T20:11:54Z

👏🙏

stlukey · 2020-06-14T06:09:17Z

🥳

btlechowski · 2020-08-06T02:05:48Z

Verification passed on

Brave	1.12.107 Chromium: 84.0.4147.105 (Official Build) (64-bit)
Revision	a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS	Ubuntu 18.04 LTS

Verification done in #9989 (comment)
Also verified UI for German and Polish locale.

Verification passed on

Brave | 1.12.108 Chromium: 84.0.4147.105 (Official Build) (64-bit)
--- | ---
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | Windows 10 OS Version 2004 (Build 19041.423)

Verification is done in Sync v2 #9989 (comment)

Verification PASSED on macOS 10.15.6 x64 using the following build:

Brave | 1.12.112 Chromium: 84.0.4147.125 (Official Build) (64-bit)
-- | --
Revision | d0784639447f2e10d32ebaf9861092b20cfde286-refs/branch-heads/4147@{#1059}
OS | macOS Version 10.15.6 (Build 19G73)

Verification was completed via Sync v2 #9989 (comment)

akash07k · 2020-08-06T11:38:05Z

Is it shipped in nightly or stable?

…

On 8/6/20, btlechowski ***@***.***> wrote: Verification passed on Brave | 1.12.107 Chromium: 84.0.4147.105 (Official Build) (64-bit) -- | -- Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943} OS | Ubuntu 18.04 LTS Verification done in #9989 Also verified UI for German and Polish locale. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: #9241 (comment)

jsecretan added the feature/sync label Apr 15, 2020

jsecretan assigned iefremov Apr 15, 2020

rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label May 5, 2020

rebron mentioned this issue May 8, 2020

Please add the ability to back up data to the cloud. #8835

Closed

petemill self-assigned this May 20, 2020

This was referenced May 28, 2020

Deleted all bookmarks, they keep coming back #3296

Closed

[Feature Request] Please Enable Password sync for Brave #7073

Closed

Bookmark Duplication #6461

Closed

[Desktop] Sync extensions among desktop clients #4094

Closed

darkdh mentioned this issue May 28, 2020

Sync v2 #9989

Closed

darkdh mentioned this issue Jun 9, 2020

Sync v2 brave/brave-core#5294

Merged

32 tasks

bsclifton mentioned this issue Jun 9, 2020

Sync option not available in Brave Desktop[Desktop] #10166

Closed

mihaiplesa closed this as completed in brave/brave-core#5294 Jun 11, 2020

darkdh added this to the 1.12.x - Nightly milestone Jun 12, 2020

mihaiplesa added QA/Test-Plan-Specified QA/Yes release-notes/include labels Jun 17, 2020

rebron added release-notes/exclude and removed release-notes/include labels Jul 20, 2020

btlechowski added the QA Pass-Linux label Aug 6, 2020

bbondy added the OS/Desktop label Aug 7, 2020

This was referenced Aug 11, 2020

Manual test run on OS X for 1.12.x - Release #11174

Closed

Manual test run on Windows x64 for 1.12.x - Release #11175

Closed

GeetaSarvadnya added the QA Pass-Win64 label Aug 12, 2020

kjozwiak added the QA Pass-macOS label Aug 12, 2020

LaurenWags added QA Pass-macOS and removed QA Pass-macOS labels Aug 12, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Sync v2 UI wiring #9241

New Sync v2 UI wiring #9241

jsecretan commented Apr 15, 2020 •

edited by petemill

Loading

iefremov commented Apr 16, 2020 •

edited

Loading

rebron commented Apr 16, 2020

rebron commented Apr 16, 2020 •

edited

Loading

madhums commented Apr 16, 2020

akash07k commented Apr 27, 2020

frankgraave commented Apr 29, 2020

ParaplegicRacehorse commented May 1, 2020

HeyITGuyFixIt commented May 2, 2020

akash07k commented May 2, 2020 via email

ParaplegicRacehorse commented May 2, 2020

NejcZdovc commented May 2, 2020

shivashranz commented May 19, 2020

akash07k commented May 19, 2020 via email

jsecretan commented May 22, 2020

akash07k commented May 22, 2020 via email

galenballew commented May 27, 2020

joel-g commented Jun 2, 2020

akash07k commented Jun 5, 2020 via email

KhimairaCrypto commented Jun 6, 2020

artella-coding commented Jun 6, 2020

jsecretan commented Jun 8, 2020

jsecretan commented Jun 8, 2020

szaimen commented Jun 11, 2020

oraculum commented Jun 12, 2020

stlukey commented Jun 14, 2020

btlechowski commented Aug 6, 2020 •

edited by kjozwiak

Loading

akash07k commented Aug 6, 2020 via email

New Sync v2 UI wiring #9241

New Sync v2 UI wiring #9241

Comments

jsecretan commented Apr 15, 2020 • edited by petemill Loading

TODO

Description

iefremov commented Apr 16, 2020 • edited Loading

rebron commented Apr 16, 2020

rebron commented Apr 16, 2020 • edited Loading

madhums commented Apr 16, 2020

akash07k commented Apr 27, 2020

frankgraave commented Apr 29, 2020

ParaplegicRacehorse commented May 1, 2020

HeyITGuyFixIt commented May 2, 2020

akash07k commented May 2, 2020 via email

ParaplegicRacehorse commented May 2, 2020

NejcZdovc commented May 2, 2020

shivashranz commented May 19, 2020

akash07k commented May 19, 2020 via email

jsecretan commented May 22, 2020

akash07k commented May 22, 2020 via email

galenballew commented May 27, 2020

joel-g commented Jun 2, 2020

akash07k commented Jun 5, 2020 via email

KhimairaCrypto commented Jun 6, 2020

artella-coding commented Jun 6, 2020

jsecretan commented Jun 8, 2020

jsecretan commented Jun 8, 2020

szaimen commented Jun 11, 2020

oraculum commented Jun 12, 2020

stlukey commented Jun 14, 2020

btlechowski commented Aug 6, 2020 • edited by kjozwiak Loading

akash07k commented Aug 6, 2020 via email

jsecretan commented Apr 15, 2020 •

edited by petemill

Loading

iefremov commented Apr 16, 2020 •

edited

Loading

rebron commented Apr 16, 2020 •

edited

Loading

btlechowski commented Aug 6, 2020 •

edited by kjozwiak

Loading