Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alignment issue for Token grants claimed in BR panel #6684

Closed
GeetaSarvadnya opened this issue Oct 31, 2019 · 4 comments · Fixed by brave/brave-core#3987
Closed

Alignment issue for Token grants claimed in BR panel #6684

GeetaSarvadnya opened this issue Oct 31, 2019 · 4 comments · Fixed by brave/brave-core#3987

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Oct 31, 2019

Description

Alignment issue for Token grants claimed in BR panel

Steps to Reproduce

  1. Launch nightly build 0.73.42 / 0.73.44 with staging flags
  2. Enable rewards and claim grants
  3. Add few verified sites to a-c table
  4. Send one-time tip and monthly tip to a verified pubs
  5. Wait for auto contribution to complete

Actual result:

Alignment issue for Token grants claimed in BR panel

After claiming grants:

image

After auto contribution:

image

Expected result:

Token grants claimed should be aligned in BR panel

Reproduces how often:

Always

Brave version (brave://version info)

Brave 0.73.44 Chromium: 78.0.3904.70 (Official Build) nightly (64-bit)
Revision edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the dev channel? Not sure
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @NejcZdovc

@LaurenWags
Copy link
Member

Reproducible with

Brave 0.71.112 Chromium: 78.0.3904.87 (Official Build) beta (64-bit)
Revision 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS macOS Version 10.13.6 (Build 17G5019)

@GeetaSarvadnya
Copy link
Author

The issue is reproducible in Windows 10 x64 -0.71.113

image

@NejcZdovc NejcZdovc added the priority/P2 A bad problem. We might uplift this to the next planned release. label Nov 11, 2019
@NejcZdovc NejcZdovc moved this from New Issues to Backlog in Rewards Nov 11, 2019
@btlechowski
Copy link

Reproduced on

Brave 0.71.114 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Ubuntu 18.04 LTS

image

@ryanml ryanml moved this from Backlog to In Progress in Rewards Nov 13, 2019
ryanml added a commit to brave/brave-core that referenced this issue Nov 13, 2019
@ryanml ryanml moved this from In Progress to Review/QA in Rewards Nov 13, 2019
Rewards automation moved this from Review/QA to Done Nov 13, 2019
@NejcZdovc NejcZdovc added this to the 1.3.x - Nightly milestone Nov 14, 2019
@btlechowski
Copy link

btlechowski commented Dec 3, 2019

Verification passed on

Brave 1.3.50 Chromium: 79.0.3945.56 (Official Build) nightly (64-bit)
Revision 73cc6bf591f792b99f8fc7cdfb8addedbd084bf8-refs/branch-heads/3945@{#788}
OS Ubuntu 18.04 LTS

Verified test plan from the description.
English
image
Polish
image
German, still reproduces, logged #7198
image

Verified passed with

Brave 1.3.85 Chromium: 79.0.3945.88 (Official Build) beta (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS macOS Version 10.14.6 (Build 18G103)
  • Verified test plan from description
    English:

English

Reproduced #7198 using Portuguese:
Portuguese

Verification passed on

Brave 1.3.87 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified test plan from the description

English:
image

Germany - Issue #7198 is reproduced

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants