Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix background padding on top sites #6746

Closed
rebron opened this issue Nov 4, 2019 · 6 comments · Fixed by brave/brave-core#3916
Closed

fix background padding on top sites #6746

rebron opened this issue Nov 4, 2019 · 6 comments · Fixed by brave/brave-core#3916
Assignees
@cezaraugusto
Labels
feature/new-tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.0.0 - Release

Comments

@rebron
Copy link
Collaborator

rebron commented Nov 4, 2019

Description

Background padding is too high when mousing over top sites widget caused by Brave Rewards widget being on.

Steps to Reproduce

  1. On New Tab page, mouseover top sites with Brave Rewards widget on.

Actual result:

Screen Shot 2019-11-02 at 5 36 41 PM

Expected result:

Screen Shot 2019-11-02 at 5 36 25 PM

Brave version (brave://version info)

71.111
73.55
@rebron
Copy link
Collaborator Author

rebron commented Nov 4, 2019

cc: @cezaraugusto

@kjozwiak
Copy link
Member

kjozwiak commented Nov 4, 2019

Reproducible on macOS 10.15.1 using the following build:

Brave 0.73.55 Chromium: 78.0.3904.87 (Official Build) nightly (64-bit)
Revision 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS macOS Version 10.15.1 (Build 19B88)

Example:

Screen Shot 2019-11-04 at 4 25 42 AM

cezaraugusto added a commit to brave/brave-core that referenced this issue Nov 7, 2019
@cezaraugusto
Make NTP widget size to fit content
27dacdd 
fix brave/brave-browser#6746

This change should be uplifted to all versions where
#3624 is present.
@cezaraugusto cezaraugusto mentioned this issue Nov 7, 2019
Merged
@rebron rebron added this to In progress in New Tab page Nov 8, 2019
This was referenced Nov 8, 2019
Merged
Merged
@cezaraugusto cezaraugusto added this to the 0.74.x - Nightly milestone Nov 8, 2019
@bsclifton
Copy link
Member

Updated milestone to be 0.72 after brave/brave-core#3938 was merged 👍

@bsclifton
Copy link
Member

Added missing labels (so that this will be QA-ed/included in release notes)

@cezaraugusto cezaraugusto mentioned this issue Nov 11, 2019
Merged
@LaurenWags
Copy link
Member

LaurenWags commented Nov 12, 2019 •
edited by GeetaSarvadnya

Verified passed with

Brave 0.71.115 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS macOS Version 10.13.6 (Build 17G5019)
  • Verified STR from description
  • Verified when Rewards widget is on and off

Screen Shot 2019-11-12 at 9 51 57 AM

Screen Shot 2019-11-12 at 9 52 16 AM

Verification passed on

Brave 0.71.115 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Ubuntu 18.04 LTS
  • Verified STR from the description
  • Verified when Rewards widget is on and off

image
image

Verification passed on

Brave 0.71.115 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified STR from the description
  • Verified when Rewards widget is on and off
    image

image

image

@kjozwiak kjozwiak mentioned this issue Nov 12, 2019
Closed
@LaurenWags
Copy link
Member

Changing to release-notes/exclude as this was a regression introduced with the Rewards NTP widget which is new to 0.71.x, so this issue does not occur in 0.70.x.

@rebron rebron moved this from In progress to Completed in New Tab page Nov 19, 2019
@rebron rebron removed this from Completed in New Tab page Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cezaraugusto cezaraugusto

Labels
feature/new-tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.0.0 - Release
Development

Successfully merging a pull request may close this issue.

Make NTP widget size to fit content brave/brave-core
7 participants
@kjozwiak @cezaraugusto @bsclifton @rebron @LaurenWags @btlechowski @GeetaSarvadnya