Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ads Settings should display BAT with 1 decimal place #6774

Closed
ryanml opened this issue Nov 5, 2019 · 4 comments · Fixed by brave/brave-core#3885
Closed

Ads Settings should display BAT with 1 decimal place #6774

ryanml opened this issue Nov 5, 2019 · 4 comments · Fixed by brave/brave-core#3885

Comments

@ryanml
Copy link
Contributor

ryanml commented Nov 5, 2019

Test plan:

  1. Enable Rewards
  2. Navigate to brave://rewards

Expected:
Estimated pending rewards displays as 0.0 BAT

Actual:
Screen Shot 2019-11-05 at 2 51 18 PM

@ryanml ryanml added this to the 0.73.x - Dev milestone Nov 5, 2019
@ryanml ryanml self-assigned this Nov 5, 2019
@ryanml ryanml added this to New Issues in Rewards via automation Nov 5, 2019
@ryanml ryanml moved this from New Issues to Review/QA in Rewards Nov 5, 2019
ryanml added a commit to brave/brave-core that referenced this issue Nov 5, 2019
Rewards automation moved this from Review/QA to Done Nov 6, 2019
@LaurenWags
Copy link
Member

LaurenWags commented Nov 20, 2019

@ryanml @NejcZdovc I'm not finding this in 1.2.x but it is merged into master (1.3.x) per https://github.com/brave/brave-core/commits/master?after=0342c2949a9ea06ff3ea146ba0c51665549c91e1+279.

Can the milestone on this issue and the PR be adjusted to reflect 1.3.x or are you going to be requesting uplift to 1.2.x?

Marking as QA/Blocked until this is decided. cc @kjozwiak @rebron

@btlechowski
Copy link

Any updates on the concerns raised by @LaurenWags ?

@NejcZdovc
Copy link
Contributor

@LaurenWags yup this was marked wrongly, changed to 1.3

@btlechowski
Copy link

btlechowski commented Jan 4, 2020

Verification passed on

Brave 1.3.81 Chromium: 79.0.3945.88 (Official Build) beta (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS Ubuntu 18.04 LTS

Verified test plan from the description. Also verified other instances of BAT values and made sure they all have 1 decimal place

image

Verified passed with

Brave 1.3.86 Chromium: 79.0.3945.88 (Official Build) beta (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS macOS Version 10.14.6 (Build 18G103)
  • Verified STR from description

Screen Shot 2020-01-08 at 4 18 33 PM

Verification passed on

Brave 1.3.91 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified STR from description
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment