Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove on NTP widgets is not translated #6869

Closed
btlechowski opened this issue Nov 11, 2019 · 2 comments · Fixed by brave/brave-core#4411
Closed

Remove on NTP widgets is not translated #6869

btlechowski opened this issue Nov 11, 2019 · 2 comments · Fixed by brave/brave-core#4411

Comments

@btlechowski
Copy link

Steps to Reproduce

  1. Change locale to Polish
  2. Open New Tab
  3. Edit a NTP widget

Actual result:

Remove is not translated
image

image

Expected result:

Remove is translated

Reproduces how often:

Always

Brave version (brave://version info)

Reproducible on

Brave 0.71.114 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Ubuntu 18.04 LTS
Brave 0.71.112 Chromium: 78.0.3904.87 (Oficjalna wersja) beta (64-bitowa)
Wersja 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
System operacyjny Windows 7 Service Pack 1 (Build 7601.24530)
Brave 0.74.7 Chromium: 78.0.3904.87 (Oficjalna wersja) nightly (64-bitowa)
Wersja 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
System operacyjny Windows 7 Service Pack 1 (Build 7601.24530)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel? yes
  • Can you reproduce this issue with the nightly channel? yes

cc @brave/legacy_qa @rebron @mkarolin @ryanml

@rebron rebron added this to P1, P2 backlog in New Tab page Nov 20, 2019
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Nov 20, 2019
@rebron rebron removed this from P1, P2 backlog in New Tab page Nov 20, 2019
@rebron rebron added this to P1 & P2 Backlog in General Nov 20, 2019
@LaurenWags
Copy link
Member

Reproduced for the languages I retested which were: Polish, French, German, Japanese

Brave 1.1.20 Chromium: 79.0.3945.74 (Official Build) (64-bit)
Revision 99b6d241cf84f7fa7434ae8a59f9e74eb1464280-refs/branch-heads/3945@{#888}
OS macOS バージョン10.13.6(ビルド17G5019)

@rebron rebron moved this from P1 & P2 Backlog to In progress in General Jan 14, 2020
cezaraugusto added a commit to brave/brave-core that referenced this issue Jan 22, 2020
bsclifton pushed a commit to brave/brave-core that referenced this issue Jan 23, 2020
General automation moved this from In progress to Completed Jan 24, 2020
@bsclifton bsclifton added this to the 1.5.x - Nightly milestone Jan 24, 2020
@LaurenWags
Copy link
Member

LaurenWags commented Feb 27, 2020

Verified passed with

Brave 1.5.102 Chromium: 80.0.3987.122 (Official Build) beta (64-bit)
Revision cf72c4c4f7db75bc3da689cd76513962d31c7b52-refs/branch-heads/3987@{#943}
OS macOS Version 10.14.6 (Build 18G3020)
  • Verified STR from description for the following languages:

Polish
Polish

French
French

German
German

Japanese
スクリーンショット 2020-02-27 午前11 31 00

Verification passed on

Brave 1.5.102 Chromium: 80.0.3987.122 (Official Build) beta (64-bit)
Revision cf72c4c4f7db75bc3da689cd76513962d31c7b52-refs/branch-heads/3987@{#943}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified STR from the description

Polish
image

French
image

German
image

Verification passed on

Brave 1.5.101 Chromium: 80.0.3987.116 (Official Build) beta (64-bit)
Revision dc00a510e4c2ae25c4d084cc3d946fc782249224-refs/branch-heads/3987@{#917}
OS Ubuntu 18.04 LTS

Verified test plan from the description

Polish
image

German
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants