Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESC does not close tip banner after tipping #7609

Closed
LaurenWags opened this issue Jan 6, 2020 · 2 comments · Fixed by brave/brave-core#4736
Closed

ESC does not close tip banner after tipping #7609

LaurenWags opened this issue Jan 6, 2020 · 2 comments · Fixed by brave/brave-core#4736

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Jan 6, 2020

Description

If you open the tip banner and don't make any changes (tip), then ESC closes the banner. However, if you tip, ESC no longer closes the banner. Note, you can tab around in the banner for a bit before you encounter #6986.

Steps to Reproduce

  1. Have rewards enabled and BAT in your wallet.
  2. Go to a verified publisher.
  3. Open tip banner.
  4. Press ESC --> Tip banner closes.
  5. Open tip banner again.
  6. Tip site (note, thank you is "in line" in 1.2.x and above)
  7. Press ESC to close banner.

Actual result:

Banner does not close, need to click on x to close banner.

Expected result:

Banner should close with ESC

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.2.41 Chromium: 79.0.3945.88 (Official Build) (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS macOS Version 10.14.6 (Build 18G103)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a 1.1x as the "thank you" was not in-line for this version, but yes for 1.2.x
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @alexwykoff @mandar-brave

@GeetaSarvadnya
Copy link

Not reproducible in Windows 10 x64 - 1.2.41
ESC key closes the tipping banner

@btlechowski
Copy link

btlechowski commented Mar 25, 2020

Verification passed on

Brave 1.7.71 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#4736
Verified for one time tip and monthly tip

Verified passed with

Brave 1.7.78 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS macOS Version 10.14.6 (Build 18G3020)

Verification passed on

Brave 1.7.82 Chromium: 80.0.3987.162 (Official Build) dev (64-bit)
Revision f2c5dd6138153bb0658091205bd1a1717f16081a-refs/branch-heads/3987@{#1034}
OS Windows 10 OS Version 1803 (Build 17134.523)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment