Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync still shows as disabled in hamburger menu #8158

Closed
rebron opened this issue Feb 10, 2020 · 3 comments · Fixed by brave/brave-core#4571
Closed

sync still shows as disabled in hamburger menu #8158

rebron opened this issue Feb 10, 2020 · 3 comments · Fixed by brave/brave-core#4571
Assignees
@simonhong
Labels
feature/sync QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.3.x - Release H...

Comments

@rebron
Copy link
Collaborator

rebron commented Feb 10, 2020 •
edited

Description

With 1.3.115 temporarily disabling sync, we still display Sync in the hamburger menu..

Actual result:

sync-hamburger

Expected result:

No Sync in hamburger menu.

Miscellaneous Information:

Filing as an issue as disabling Sync should remove all UI. However, showing as disabled maybe preferred versus completely disappearing.
@rebron rebron added this to the 1.3.x - Release Hotfix 1 milestone Feb 10, 2020
@kjozwiak
Copy link
Member

Looks similar on macOS 10.15.3 x64 using the following build:

Brave 1.3.115 Chromium: 80.0.3987.87 (Official Build) (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS macOS Version 10.15.3 (Build 19D76)

Screen Shot 2020-02-10 at 1 01 12 AM

Probably not a blocker as it appears disabled and users won't be able to interact with that particular element. However, we should remove it so it doesn't cause any confusions as users might wonder why they can't enable sync anymore.

@simonhong simonhong self-assigned this Feb 10, 2020
simonhong added a commit to brave/brave-core that referenced this issue Feb 10, 2020
@simonhong
Hide sync menu from app menu if it's disabled
6c6c279 
and fix failed app menu test.

fix brave/brave-browser#8160
fix brave/brave-browser#8158 (only for 1.3)
@simonhong simonhong mentioned this issue Feb 10, 2020
Merged
32 tasks
simonhong added a commit to brave/brave-core that referenced this issue Feb 10, 2020
@simonhong
Hide sync menu from app menu if it's disabled
2eff01b 
fix brave/brave-browser#8158
@simonhong simonhong mentioned this issue Feb 10, 2020
Merged
32 tasks
simonhong added a commit to brave/brave-core that referenced this issue Feb 10, 2020
@simonhong
Hide sync menu from app menu if it's disabled
31e39ac 
fix brave/brave-browser#8158
This was referenced Feb 10, 2020
Closed
Closed
@kjozwiak
Copy link
Member

kjozwiak commented Feb 10, 2020 •
edited

Removing this from https://github.com/brave/brave-browser/milestone/79 as per earlier conversations. This will be addressed in another release if we decide to remove Sync from the hamburger menu while it's temporarily disabled. CCing @rebron

@kjozwiak kjozwiak added this to Untriaged backlog in Sync via automation Feb 10, 2020
@kjozwiak kjozwiak removed this from the 1.3.x - Release Hotfix 1 milestone Feb 10, 2020
Sync automation moved this from Untriaged backlog to Completed Feb 11, 2020
@simonhong simonhong reopened this Feb 11, 2020
@kjozwiak kjozwiak added this to the 1.3.x - Release Hotfix 2 milestone Feb 12, 2020
@GeetaSarvadnya
Copy link
Collaborator

GeetaSarvadnya commented Feb 17, 2020 •
edited by LaurenWags

Verification passed on

Brave 1.3.116 Chromium: 80.0.3987.106 (Official Build) (64-bit)
Revision f68069574609230cf9b635cd784cfb1bf81bb53a-refs/branch-heads/3987@{#882}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verification passed on

Brave 1.3.116 Chromium: 80.0.3987.106 (Official Build) (64-bit)
Revision f68069574609230cf9b635cd784cfb1bf81bb53a-refs/branch-heads/3987@{#882}
OS Linux
  • Verified no sync option in hamburger menu when sync is disabled
    image
  • Verified sync option is not shown in Normal/Private/Tor windows

Verified passed with

Brave 1.3.116 Chromium: 80.0.3987.106 (Official Build) (64-bit)
Revision f68069574609230cf9b635cd784cfb1bf81bb53a-refs/branch-heads/3987@{#882}
OS macOS Version 10.14.6 (Build 18G3020)
  • Verified Sync is not displayed in hamburger menu when flag is default/disabled on Normal, Private, and Tor windows:

Screen Shot 2020-02-18 at 10 02 00 AM

Screen Shot 2020-02-18 at 10 08 34 AM

Screen Shot 2020-02-18 at 10 08 45 AM

  • Verified enabling the flag does show the Sync option in hamburger menu:

Screen Shot 2020-02-18 at 9 58 50 AM

Screen Shot 2020-02-18 at 10 09 41 AM

Screen Shot 2020-02-18 at 10 09 52 AM

@rebron rebron removed this from Completed in Sync Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
feature/sync QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.3.x - Release Hotfix 2
Development

Successfully merging a pull request may close this issue.

Hide sync menu from app menu if it's disabled brave/brave-core
6 participants
@kjozwiak @rebron @simonhong @srirambv @LaurenWags @GeetaSarvadnya