Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fingerprinting 2.0: Web Audio #9187

Closed
pes10k opened this issue Apr 13, 2020 · 3 comments · Fixed by brave/brave-core#5794
Closed

Fingerprinting 2.0: Web Audio #9187

pes10k opened this issue Apr 13, 2020 · 3 comments · Fixed by brave/brave-core#5794
Assignees
@pilgrim-brave
Labels
feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields privacy privacy-pod Feature work for the Privacy & Web Compatibility pod QA/No release-notes/include
Milestone
1.11.x - Release #1

Comments

@pes10k
Copy link
Contributor

pes10k commented Apr 13, 2020 •
edited
Loading

This is a sub-issue of the larger fingerprint defense reorganization issue: #8787

Audio data serialization endpoints

AnalyserNode.getByteTimeDomainData
AnalyserNode.getFloatTimeDomainData
AnalyserNode.getByteFrequencyData
AnalyserNode.getFloatFrequencyData
AudioBuffer.getChannelData
AudioBuffer.copyFromChannel

default protection: Farble output volume by [0,-.01] under eTLD+1 session seed
max protection: randomly generate low amplitude white noise under eTLD+1 session seed (with max amplitude / volume being 1% of max representable volume).
@pes10k pes10k added privacy feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields privacy-pod Feature work for the Privacy & Web Compatibility pod labels Apr 13, 2020
@pes10k pes10k mentioned this issue Apr 13, 2020
Closed
10 tasks
@pilgrim-brave pilgrim-brave mentioned this issue Jun 9, 2020
Merged
32 tasks
@brave-builds brave-builds mentioned this issue Jun 11, 2020
Merged
4 tasks
@bsclifton bsclifton added this to the 1.12.x - Nightly milestone Jun 18, 2020
@bsclifton bsclifton mentioned this issue Jun 19, 2020
Closed
4 tasks
@pkalogiros pkalogiros mentioned this issue Jun 21, 2020
Open
@abrahamjuliot
Copy link

@pes10k
Side note: Should AudioBuffer.copyFromChannel be added in this list? It should match AudioBuffer.getChannelData.

@pes10k
Copy link
Contributor Author

pes10k commented Jun 26, 2020

@abrahamjuliot that is a very good question! Let me check and see if thats already covered by the current instrumentation point and get back to you. Thanks for the suggestion!

@pes10k
Copy link
Contributor Author

pes10k commented Jun 26, 2020

@abrahamjuliot so good news from @pilgrim-brave (who's doing the actual hard work on all this), we already cover copyFromChannel, I just neglected to include it in the issue text. So, i'll update the issue text now to make it clear. Apologies for the omission, and takes again for catching it!

https://github.com/brave/brave-core/blob/master/patches/third_party-blink-renderer-modules-webaudio-audio_buffer.cc.patch#L44

@LaurenWags LaurenWags mentioned this issue Jul 15, 2020
Closed
@pes10k pes10k mentioned this issue Jul 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pilgrim-brave pilgrim-brave

Labels
feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields privacy privacy-pod Feature work for the Privacy & Web Compatibility pod QA/No release-notes/include
Projects
None yet
Milestone
1.11.x - Release #1
Development

Successfully merging a pull request may close this issue.

Implement farbling levels for webaudio brave/brave-core
5 participants
@pes10k @bbondy @bsclifton @abrahamjuliot @pilgrim-brave