Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded from Chromium 87.0.4280.60 to Chromium 87.0.4280.66 (1.18.x). #12763

Merged
merged 2 commits into from
Nov 18, 2020

Conversation

mkarolin
Copy link
Contributor

@mkarolin mkarolin commented Nov 18, 2020

Fixes #12727
Fixes #12741

Related PR: brave/brave-core#7181

Uplift from #12728
Uplift from #12742

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

bbondy and others added 2 commits November 18, 2020 09:44
Upgraded from Chromium 87.0.4280.60 to Chromium 87.0.4280.63.
Upgraded from Chromium 87.0.4280.63 to Chromium 87.0.4280.66.
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.18.x approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak merged commit 975db2c into 1.18.x Nov 18, 2020
@kjozwiak kjozwiak deleted the 87.0.4280.66-1.18.x branch November 18, 2020 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants