Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MacOS notarization #5485

Merged
merged 1 commit into from Oct 30, 2019
Merged

Add MacOS notarization #5485

merged 1 commit into from Oct 30, 2019

Conversation

mbacchi
Copy link
Contributor

@mbacchi mbacchi commented Jul 31, 2019

Work in progress.

Depends upon changes in brave-core branch issue_5177.

Requires NPM configuration such as:

npm config --userconfig=.npmrc set notary_user APPLEID_EMAIL_ADDRESS
npm config --userconfig=.npmrc set notary_password APPLE_APP_SPECIFIC_PASSWORD

Fixes: #5177
Related: brave/brave-core#3725

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@mbacchi mbacchi added the QA/No label Jul 31, 2019
@mbacchi mbacchi added this to the 0.70.x - Nightly milestone Jul 31, 2019
@mbacchi mbacchi self-assigned this Jul 31, 2019
@bsclifton bsclifton removed this from the 0.70.x - Beta milestone Sep 12, 2019
@bsclifton
Copy link
Member

Removing milestone as this is not reviewed/approved/merged 👍

@mbacchi mbacchi force-pushed the issue_5177 branch 2 times, most recently from 73b812a to ac35737 Compare October 3, 2019 13:04
@mbacchi mbacchi changed the title WIP: Add MacOS notarization Add MacOS notarization Oct 16, 2019
@mbacchi mbacchi marked this pull request as ready for review October 16, 2019 20:19
lib/createDist.js Outdated Show resolved Hide resolved
mihaiplesa
mihaiplesa previously approved these changes Oct 23, 2019
bsclifton
bsclifton previously approved these changes Oct 29, 2019
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

mihaiplesa
mihaiplesa previously approved these changes Oct 30, 2019
@mihaiplesa mihaiplesa merged commit 9a29dce into master Oct 30, 2019
@mihaiplesa mihaiplesa deleted the issue_5177 branch October 30, 2019 17:45
mbacchi added a commit that referenced this pull request Nov 1, 2019
mbacchi added a commit that referenced this pull request Nov 1, 2019
mbacchi added a commit that referenced this pull request Nov 1, 2019
mbacchi added a commit that referenced this pull request Nov 3, 2019
bsclifton pushed a commit that referenced this pull request Nov 3, 2019
bsclifton added a commit that referenced this pull request Nov 4, 2019
Add MacOS notarization (Uplift of #5485 to 0.72.x)
bsclifton added a commit that referenced this pull request Nov 4, 2019
Add MacOS notarization (Uplift of #5485 to 0.71.x)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add macOS Gatekeeper/notarization support
4 participants