Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MacOS notarization (Uplift of #5485 to 0.71.x) #6739

Merged
merged 2 commits into from Nov 4, 2019
Merged

Add MacOS notarization (Uplift of #5485 to 0.71.x) #6739

merged 2 commits into from Nov 4, 2019

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Nov 3, 2019 •
edited

Uplift of #5485
Related brave/brave-core#3857

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@bsclifton bsclifton added this to the 0.71.x - Beta milestone Nov 3, 2019
@bsclifton bsclifton requested a review from a team November 3, 2019 17:45
@bsclifton bsclifton self-assigned this Nov 3, 2019
@bsclifton bsclifton mentioned this pull request Nov 3, 2019
Closed
4 tasks
@brave-builds brave-builds mentioned this pull request Nov 3, 2019
Merged
4 tasks
rebron
rebron approved these changes Nov 4, 2019
View reviewed changes
Copy link
Collaborator

@rebron rebron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@bsclifton bsclifton merged commit 7fb055f into 0.71.x Nov 4, 2019
@bsclifton bsclifton deleted the pr3725_issue_5177_0.71.x branch November 4, 2019 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebron rebron rebron approved these changes

Assignees

@bsclifton bsclifton

Labels
None yet
Projects
None yet
Milestone
1.0.0 - Release
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bsclifton @rebron @mbacchi @mihaiplesa