Skip to content

Commit

Permalink
Override DoNotTrack preference strings
Browse files Browse the repository at this point in the history
Text originally updated in #13515
But it updates a file that is auto-generated. This uses our own text.

Fixes brave/brave-browser#17177
  • Loading branch information
bsclifton committed Jun 20, 2022
1 parent c866433 commit 092fa66
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
3 changes: 3 additions & 0 deletions app/brave_settings_strings.grdp
Original file line number Diff line number Diff line change
Expand Up @@ -398,6 +398,9 @@
<message name="IDS_SETTINGS_SITE_SETTINGS_USE_EPHEMERAL_STORAGE" desc="Label for sites in site settings enabling cookies cleanup when all windows with the site are clsoed.">
Clear on site close
</message>
<message name="IDS_SETTINGS_BRAVE_ENABLE_DO_NOT_TRACK_DIALOG_TEXT" desc="The text of a confirmation dialog that confirms that the user want to send the 'Do Not Track' header">
Enabling "Do not track" means that a request to not be tracked will be included each time you browse to a new website. Any effect depends on whether the website responds to this request, and how it's interpreted. For example, some websites may respond by only showing you ads that aren't based on other sites you've visited. Even with this "Do not track" request in place, many websites will still collect and use your browsing data. <ph name="BEGIN_LINK">&lt;a target="_blank" href="$1"&gt;</ph>Learn more<ph name="END_LINK">&lt;/a&gt;<ex>&lt;/a&gt;</ex></ph>
</message>

<!-- Settings / Privacy and security / Security -->
<!-- Safe browsing -->
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
#include "chrome/browser/media/router/media_router_feature.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/common/pref_names.h"
#include "chrome/common/url_constants.h"
#include "chrome/common/webui_url_constants.h"
#include "chrome/grit/chromium_strings.h"
#include "chrome/grit/generated_resources.h"
Expand Down Expand Up @@ -544,6 +545,12 @@ void BraveAddCommonStrings(content::WebUIDataSource* html_source,
l10n_util::GetStringFUTF16(
IDS_SETTINGS_BRAVE_REWARDS_AUTO_CONTRIBUTE_DESC_LABEL,
kBraveTermsOfUseURL, kBravePrivacyPolicyURL));

html_source->AddString(
"doNotTrackDialogMessage",
l10n_util::GetStringFUTF16(
IDS_SETTINGS_BRAVE_ENABLE_DO_NOT_TRACK_DIALOG_TEXT,
base::ASCIIToUTF16(chrome::kDoNotTrackLearnMoreURL)));
}

void BraveAddResources(content::WebUIDataSource* html_source,
Expand Down

0 comments on commit 092fa66

Please sign in to comment.