Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update text in Do Not Track dialog box #17177

Open
Miyayes opened this issue Jul 26, 2021 · 5 comments
Open

Update text in Do Not Track dialog box #17177

Miyayes opened this issue Jul 26, 2021 · 5 comments
Labels
needs-text-change This change requires some careful wording. OS/Desktop priority/P4 Planned work. We expect to get to it "soon". privacy/feature User-facing privacy- & security-focused feature work. privacy QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
Settings

Comments

@Miyayes
Copy link
Contributor

Miyayes commented Jul 26, 2021 •
edited by bsclifton

Test plan

Copy (in English) should match text here by @rmcfadden3:
brave/brave-core#13515 (comment)

Description

According to @diracdeltas, we can remove all the text starting with "for example ...". The paragraph should end on "... browsing data."

This text was inherited from Chromium.

image

Reported here by community: https://www.reddit.com/r/brave_browser/comments/opj8t6/what_does_brave_mean_by_improve_security/
@Miyayes Miyayes added needs-text-change This change requires some careful wording. privacy/feature User-facing privacy- & security-focused feature work. OS/Desktop good first issue labels Jul 26, 2021
@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Jul 26, 2021
@rebron rebron added this to P4 backlog in Settings Jul 27, 2021
@m4thieulavoie
Copy link

I would be happy to give this one a shot 😄

@m4thieulavoie m4thieulavoie mentioned this issue Jul 28, 2021
Closed
24 tasks
@jumde jumde added the privacy label Sep 1, 2021
@subhamgcon
Copy link

Description

According to @diracdeltas, we can remove all the text starting with "for example ...". The paragraph should end on "... browsing data."

This text was inherited from Chromium.

image

Reported here by community: https://www.reddit.com/r/brave_browser/comments/opj8t6/what_does_brave_mean_by_improve_security/

Hey I am a beginner, Can I take up and solve this issue and it is labelled as a good first issue?

wadehrarshpreet added a commit to wadehrarshpreet/brave-core that referenced this issue May 27, 2022
@wadehrarshpreet
fix(17177): update do not track dialog text
10a1af2 
resolves brave/brave-browser#17177
@wadehrarshpreet wadehrarshpreet mentioned this issue May 27, 2022
Merged
25 tasks
@bsclifton bsclifton added this to the 1.41.x - Nightly milestone Jun 6, 2022
@stephendonner
Copy link

stephendonner commented Jun 9, 2022 •
edited

Verified PASSED using

Brave 1.41.47 Chromium: 102.0.5005.78 (Official Build) nightly (x86_64)
Revision df6dbb5a9fd82af3f567198af2eb5fb4876ef99c-refs/branch-heads/5005_59@{#3}
OS macOS Version 12.5 (Build 21G5037d)

Steps:

  1. installed 1.41.47
  2. launched Brave
  3. opened brave://settings/cookies
  4. clicked on Send a "Do not track" request with your browsing traffic, toggling it to Enabled
  5. compared the resulting dialog to that from 1.39.120

Confirmed text changes

1.41.47 1.39.120
Screen Shot 2022-06-09 at 2 44 18 AM Screen Shot 2022-06-09 at 2 45 53 AM

@bsclifton bsclifton reopened this Jun 10, 2022
@bsclifton
Copy link
Member

This file is auto-generated and got overwritten with Chromium 103 upgrade. Looking at the override fix now

@bsclifton bsclifton removed this from the 1.41.x - Nightly milestone Jun 10, 2022
@bsclifton bsclifton self-assigned this Jun 10, 2022
bsclifton added a commit to brave/brave-core that referenced this issue Jun 10, 2022
@bsclifton
Put updated DNT strings into override
bcc435a 
Changes originally done in #13515
But it updates a file that is auto-generated. This is moving to
overrides.

Fixes brave/brave-browser#17177
@bsclifton bsclifton mentioned this issue Jun 10, 2022
Closed
25 tasks
bsclifton added a commit to brave/brave-core that referenced this issue Jun 10, 2022
@bsclifton
Override DoNotTrack preference strings
1e27c51 
Text originally updated in #13515
But it updates a file that is auto-generated. This uses our own text.

Fixes brave/brave-browser#17177
bsclifton added a commit to brave/brave-core that referenced this issue Jun 20, 2022
@bsclifton
Override DoNotTrack preference strings
092fa66 
Text originally updated in #13515
But it updates a file that is auto-generated. This uses our own text.

Fixes brave/brave-browser#17177
@brave-builds brave-builds added this to the 1.42.x - Nightly milestone Jun 22, 2022
@bsclifton bsclifton removed this from the 1.42.x - Release milestone Jul 27, 2022
@bsclifton bsclifton removed their assignment Jul 27, 2022
@bsclifton
Copy link
Member

Removed the good-first-issue label. Some of these text changes are very tricky due to Chromium patching ☹️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-text-change This change requires some careful wording. OS/Desktop priority/P4 Planned work. We expect to get to it "soon". privacy/feature User-facing privacy- & security-focused feature work. privacy QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
Settings
P4 backlog
Milestone
No milestone
8 participants
@stephendonner @jumde @bsclifton @rebron @Miyayes @m4thieulavoie @brave-builds @subhamgcon