Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated gemini widget's title and copy text #10095

Merged
merged 1 commit into from Sep 15, 2021

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Sep 15, 2021

fix brave/brave-browser#18121

Screen Shot 2021-09-15 at 11 24 17 AM

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@simonhong simonhong self-assigned this Sep 15, 2021
Copy link
Collaborator

@rebron rebron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. ++

@simonhong
Copy link
Member Author

Merged w/o waiting CI because this only changes text.

@simonhong simonhong merged commit 5d29af1 into master Sep 15, 2021
@simonhong simonhong deleted the update_gemini_widget_label branch September 15, 2021 02:32
@simonhong simonhong added this to the 1.31.x - Nightly milestone Sep 15, 2021
brave-builds pushed a commit that referenced this pull request Sep 15, 2021
@stephendonner
Copy link
Collaborator

Verified PASSED using

Brave 1.31.44 Chromium: 94.0.4606.41 (Official Build) nightly (x86_64)
Revision 333e85df3c9b656b518b5f1add5ff246365b6c24-refs/branch-heads/4606@{#845}
OS macOS Version 11.6 (Build 20G165)

Steps:

  1. new profile
  2. launched Brave
  3. opened the new-tab page
  4. examined the copy on the Gemini widget

Confirmed the text change

example example
Screen Shot 2021-09-15 at 8 42 28 AM Screen Shot 2021-09-15 at 8 44 17 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants