Support separate lists for origin and target languages #10338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atuchin-m
force-pushed
the
support-separate-lists-in-translate
branch
from
e22a366
to
2117f2e
Compare
atuchin-m
commented
Oct 5, 2021
atuchin-m
force-pushed
the
support-separate-lists-in-translate
branch
from
57db559
to
353a5ca
Compare
atuchin-m
changed the title
atuchin-m
commented
Oct 6, 2021
components/translate/core/browser/brave_translate_language_filter.cc
Outdated
Show resolved
Hide resolved
iefremov
reviewed
Oct 6, 2021
browser/net/brave_translate_redirect_network_delegate_helper_unittest.cc
Outdated
Show resolved
Hide resolved
atuchin-m
force-pushed
the
support-separate-lists-in-translate
branch
from
69c1471
to
e915125
Compare
goodov
reviewed
Oct 7, 2021
chromium_src/components/translate/core/browser/translate_manager.h
Outdated
Show resolved
Hide resolved
chromium_src/components/translate/core/browser/translate_manager.cc
Outdated
Show resolved
Hide resolved
chromium_src/components/translate/core/browser/translate_manager.cc
Outdated
Show resolved
Hide resolved
components/translate/core/browser/brave_translate_language_filter.cc
Outdated
Show resolved
Hide resolved
chromium_src/chrome/browser/ui/translate/translate_bubble_model_impl.cc
Outdated
Show resolved
Hide resolved
chromium_src/chrome/browser/ui/translate/translate_bubble_model_impl.h
Outdated
Show resolved
Hide resolved
chromium_src/chrome/browser/ui/translate/translate_bubble_model_impl.cc
Outdated
Show resolved
Hide resolved
goodov
approved these changes
Oct 8, 2021
moritzhaller
approved these changes
Oct 8, 2021
iefremov
approved these changes
Oct 8, 2021
atuchin-m
force-pushed
the
support-separate-lists-in-translate
branch
from
56a8522
to
3461bbd
Compare
bridiver
reviewed
Oct 8, 2021
| } | ||
| } | ||
|
|
||
| TranslateBubbleModelImpl::~TranslateBubbleModelImpl() = default; |
There was a problem hiding this comment.
can't we accomplish the same thing here by subclass/override TranslateUIDelegate
in TranslateBubbleView? Seems like that would be simpler and cleaner, no?
There was a problem hiding this comment.
Good idea @bridiver, thanks.
Would you mind if I did it in the next PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#18592
Two separate languages lists (one for source and once for target) are implemented to supported Brave backend restrictions.
We agreed to disable the buildflag again
enable_brave_translate_gobefore merging so nothing will be changed before enabling it again.Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: