Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset sync chain and clear prefs right away when transaport state is not active (uplift to 1.31.x) #10846

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Reset sync chain and clear prefs right away when transaport state is not active (uplift to 1.31.x) #10846

merged 1 commit into from
Nov 4, 2021

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Nov 3, 2021 •
edited by kjozwiak
Loading

Uplift of #10841
Resolves brave/brave-browser#19199

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner November 3, 2021 07:02
@brave-builds brave-builds requested a review from a team November 3, 2021 07:02
@brave-builds brave-builds self-assigned this Nov 3, 2021
@brave-builds brave-builds added this to the 1.31.x - Release #3 milestone Nov 3, 2021
AlexeyBarabash
AlexeyBarabash approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

kjozwiak
kjozwiak approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.31.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #10841 (comment).

@kjozwiak kjozwiak merged commit 390ea4d into 1.31.x Nov 4, 2021
@kjozwiak kjozwiak deleted the pr10841_sync-reset-non-active_1.31.x branch November 4, 2021 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@AlexeyBarabash AlexeyBarabash AlexeyBarabash approved these changes

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.31.x - Release #4
4 participants
@brave-builds @kjozwiak @AlexeyBarabash @brave-browser-releases