Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot leave sync chain when offline/error #19199

Closed
darkdh opened this issue Nov 3, 2021 · 3 comments · Fixed by brave/brave-core#10841
Closed

Cannot leave sync chain when offline/error #19199

darkdh opened this issue Nov 3, 2021 · 3 comments · Fixed by brave/brave-core#10841

Comments

@darkdh
Copy link
Member

darkdh commented Nov 3, 2021

Description

Steps to Reproduce

  1. Turn off network
  2. Create sync chain offline
  3. Try to leave sync chain

Actual result:

It will stuck in the same sync chain until network came online or server error resolved

Expected result:

Reset should take effect immediately

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 9, 2021

Verification passed on


Brave | 1.31.91 Chromium: 95.0.4638.69 (Official Build) (64-bit)
-- | --
Revision | 6a1600ed572fedecd573b6c2b90a22fe6392a410-refs/branch-heads/4638@{#984}
OS | Windows 10 Version 21H1 (Build 19043.1288)

  • Verified the STR from the description

Clean profile

Initial Sync Chain Disabled Network Leaving Sync Chain Left Sync Chain Left Sync Chain
image image image image image

Upgrade profile

  • Installed 1.31.88 and sync with 2nd device and add bookmarks in 1.31.88, upgrade the profile to 1.31.91 and disconnect the network and try to leave the sync chain, and confirm user can leave the sync chain when the network is disabled
1.31.88 1.31.91 Disconnect network Leaving sync chain Left sync chain
image image image image image

Verified using:

Brave | 1.31.91 Chromium: 95.0.4638.69 (Official Build) (x86_64)
-- | --
Revision | 6a1600ed572fedecd573b6c2b90a22fe6392a410-refs/branch-heads/4638@{#984}
OS | macOS Version 11.6.1 (Build 20G224)

Verified using the STR/Cases outlined via #19199. Basically made sure that you can leave a sync chain while the network is disabled.

Initial Sync Chain Disabled Network Leaving Sync Chain Left Sync Chain Left Sync Chain
1 2 3 4 5

Encountered #11166 (comment) while testing.


Verification passed on

Brave 1.31.91 Chromium: 95.0.4638.69 (Official Build) (64-bit)
Revision 6a1600ed572fedecd573b6c2b90a22fe6392a410-refs/branch-heads/4638@{#984}
OS Ubuntu 18.04 LTS

Verified test plan from the description

19199

@btlechowski
Copy link

Looks similar to #10879

@stephendonner
Copy link

Verified PASSED using Brave 1.31.91, Chromium 95.0.4638.69 on Android 9, Google Pixel XL.

Steps:

  1. new install
  2. created Sync chain
  3. added desktop machine using Sync code words
  4. disconnected from Wi-Fi
  5. tapped on the trash-can icon to Delete / Remove the Sync seed device (Google Pixel XL) from the Sync chain

Confirmed I was able to leave the Sync chain successfully while offline.

example example example example
Screenshot_20211109-114549 Screenshot_20211109-114618 Screenshot_20211109-115116 Screenshot_20211109-114724

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment