Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for default feature state overrides using default_state rewrite #10854

Closed
wants to merge 5 commits into from

Conversation

goodov
Copy link
Member

@goodov goodov commented Nov 3, 2021

Resolves brave/brave-browser#18829

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@goodov goodov requested review from a team as code owners November 3, 2021 15:24
@goodov goodov self-assigned this Nov 3, 2021
@goodov goodov force-pushed the issues/18829 branch 2 times, most recently from f586be5 to 5f3e11c Compare November 3, 2021 17:22
@goodov goodov changed the title Add support for default feature state overrides Add support for default feature state overrides using default_state rewrite Nov 4, 2021
@goodov goodov closed this Nov 5, 2021
@goodov
Copy link
Member Author

goodov commented Nov 5, 2021

This implementation changes base::Feature implementation in a way that it becomes non-constexpr for the compiler. This breaks some unusual base::Feature usages which may occasionally appear in upstream code. This includes default_state check in a global object construction and base::Feature passing in a callback.

Alternative approach can be found here #10878

@goodov goodov deleted the issues/18829 branch November 5, 2021 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant