Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Brave news - cards scroll fixes and tweaks #12078

Merged
merged 1 commit into from
Feb 1, 2022
Merged

[Android] Brave news - cards scroll fixes and tweaks #12078

merged 1 commit into from
Feb 1, 2022

Conversation

alexsafe
Copy link
Contributor

Resolves brave/brave-browser#20773
Resolves brave/brave-browser#20772
Resolves brave/brave-browser#20410
Resolves brave/brave-browser#20769
Resolves brave/brave-browser#20771
Resolves brave/brave-browser#20769
Resolves brave/brave-browser#20768
Resolves brave/brave-browser#20766

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@alexsafe alexsafe added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Jan 31, 2022
@alexsafe alexsafe added this to the 1.37.x - Nightly milestone Jan 31, 2022
@alexsafe alexsafe self-assigned this Jan 31, 2022
SergeyZhukovsky
SergeyZhukovsky reviewed Feb 1, 2022
View reviewed changes
android/java/org/chromium/chrome/browser/ntp/BraveNewTabPageLayout.java Outdated
}
InitBraveNewsController();
initNews();
Tab tab1 = BraveActivity.getBraveActivity().getActivityTab();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A check if (BraveActivity.getBraveActivity() != null should probably be before that line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SergeyZhukovsky the whole "tab1" block was useless there i think it was part of some dev logs . Same as below

SergeyZhukovsky
SergeyZhukovsky reviewed Feb 1, 2022
View reviewed changes
android/java/org/chromium/chrome/browser/ntp/BraveNewTabPageLayout.java Outdated
@@ -644,11 +681,18 @@ protected void onDetachedFromWindow() {
BraveActivity.getBraveActivity().setNewsItemsFeedCards(mNewsItemsFeedCard);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are no checks on if (BraveActivity.getBraveActivity() != null) { but I see them in other places. Should we check it here as well?

SergeyZhukovsky
SergeyZhukovsky reviewed Feb 1, 2022
View reviewed changes
android/java/org/chromium/chrome/browser/ntp/BraveNewTabPageLayout.java Outdated
mSettingsBar.setVisibility(View.GONE);
mSettingsBar.setAlpha(0f);
}
Tab tab = BraveActivity.getBraveActivity().getActivityTab();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are no checks on if (BraveActivity.getBraveActivity() != null) { but I see them in other places. Should we check it here as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SergeyZhukovsky i removed the entire "Tab" block. leftover

SergeyZhukovsky
SergeyZhukovsky approved these changes Feb 1, 2022
View reviewed changes
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@alexsafe
Copy link
Contributor Author

alexsafe commented Feb 1, 2022 •
edited by srirambv
Loading

@brave/legacy_qa tagging just to ease the access some of the important issues for News are here

@alexsafe alexsafe merged commit 4b54bb2 into master Feb 1, 2022
@alexsafe alexsafe deleted the bravenews-android-cards branch February 1, 2022 15:27
@alexsafe alexsafe mentioned this pull request Feb 15, 2022
Merged
7 tasks
@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 12 and/or Samsung Tab A with Android 10 running 1.37.55 x64 nightly build

brave/brave-browser#20773 - Passed
  • Verified news feed doesn't repeat when scrolled down
  • Verified disabling and re-enabling Brave news doesn't cause the issue again
20773.mp4
brave/brave-browser#20772 - Passed
  • Verified disable and re-enable Brave News, start to show the feed immediately within the same NTP
20772.mp4
brave/brave-browser#20410 - Passed
  • Verified clicking on the widget menu loads the menu options and able to go into widget settings
  • Verified tapping on stats widget brings up the stats details page
  • Verified tapping on Binance button loads the Binance widget
  • Verified tapping on a top tile loads the page
20410.mp4
brave/brave-browser#20771 - Failed
brave/brave-browser#20769 - Passed
  • Verified opening and closing new tabs via tab tray doesn't cause any crash
  • Verified for both tab group enabled and disbaled
  • Logged followup issue #21167
20769.mp4
brave/brave-browser#20768 - Passed
  • Verified brave news settings bar doesn't show up on tab tray when tabs are closed
20768.mp4
brave/brave-browser#20766 - Partial Pass or Failed
  • Verified steps from issue description. But found the news bar is still shown on tab tray and the UI transition seems pretty bad.
  • Logged followup issue #21169

@mattmcalister mattmcalister added this to Backlog - Android in Brave News Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyZhukovsky SergeyZhukovsky SergeyZhukovsky approved these changes

@deeppandya deeppandya Awaiting requested review from deeppandya deeppandya is a code owner

@AlexeyBarabash AlexeyBarabash Awaiting requested review from AlexeyBarabash

Assignees

@alexsafe alexsafe

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
No open projects
Brave News
Android
Milestone
1.37.x - Release
3 participants
@alexsafe @srirambv @SergeyZhukovsky