Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bravenews android fixes74 #12155

Merged
merged 5 commits into from
Feb 5, 2022
Merged

Bravenews android fixes74 #12155

merged 5 commits into from
Feb 5, 2022

Conversation

alexsafe
Copy link
Contributor

@alexsafe alexsafe commented Feb 4, 2022

Resolves brave/brave-browser#20899
Resolves brave/brave-browser#20900
Resolves brave/brave-browser#20850
Resolves brave/brave-browser#20901
Resolves brave/brave-browser#19854

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@alexsafe alexsafe added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Feb 4, 2022
@alexsafe alexsafe added this to the 1.37.x - Nightly milestone Feb 4, 2022
@alexsafe alexsafe self-assigned this Feb 4, 2022
@alexsafe alexsafe marked this pull request as ready for review February 4, 2022 22:38
@github-actions github-actions bot added rebase and removed rebase labels Feb 4, 2022
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@alexsafe alexsafe merged commit aaa4f13 into master Feb 5, 2022
@alexsafe alexsafe deleted the bravenews-android-fixes74 branch February 5, 2022 01:55
@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 12 and/or Samsung Tab A with Android 10 running 1.37.55 x64 nightly build

brave/brave-browser#20899 - Passed
  • Verified able to open widget menu after scrolling back up from news feed
  • Verified menu is opened on all the widgets
20899.mp4
brave/brave-browser#20900 - Passed
  • Verified reload on brave news feed jumps back to NTP view
20900.-.Android.Tab.mp4
brave/brave-browser#20850 - Passed
  • Verified opening and closing new tabs via tab tray doesn't cause any crash
  • Verified for both tab group enabled and disbaled
  • Encountered #21167
brave/brave-browser#20901 - Passed
  • Verified removing all widgets doesn't cause the feed to scroll up like before
  • Verified re-adding the widgets doesn't cause any UI issues with news feed
20901.mp4
brave/brave-browser#19854 - Failed
  • Swipe on widgets still causes News feed to scroll up. Only when you swipe slowly on the widget does it scroll through the widget. Followup issue is already logged for it #21166

@mattmcalister mattmcalister added this to Backlog - Android in Brave News Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
No open projects
Brave News
Android
3 participants