-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bravenews android fixes74 #12155
Merged
Merged
Bravenews android fixes74 #12155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexsafe
added
CI/skip-linux
CI/skip-macos-x64
Do not run CI builds for macOS x64
CI/skip-ios
Do not run CI builds for iOS
labels
Feb 4, 2022
alexsafe
requested review from
deeppandya,
SergeyZhukovsky,
tapanmodh and
AlexeyBarabash
February 4, 2022 22:36
alexsafe
force-pushed
the
bravenews-android-fixes74
branch
from
February 4, 2022 22:38
b0a149e
to
529421d
Compare
alexsafe
force-pushed
the
bravenews-android-fixes74
branch
from
February 4, 2022 22:56
529421d
to
6a38337
Compare
SergeyZhukovsky
approved these changes
Feb 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
7 tasks
Verification passed on Oppo Reno 5 with Android 12 and/or Samsung Tab A with Android 10 running 1.37.55 x64 nightly build brave/brave-browser#20899 - Passed
20899.mp4brave/brave-browser#20900 - Passed
20900.-.Android.Tab.mp4brave/brave-browser#20850 - Passed
brave/brave-browser#20901 - Passed
20901.mp4brave/brave-browser#19854 - Failed
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#20899
Resolves brave/brave-browser#20900
Resolves brave/brave-browser#20850
Resolves brave/brave-browser#20901
Resolves brave/brave-browser#19854
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: