Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IPFS updater version to brave://ipfs page #12159

Merged
merged 2 commits into from Feb 7, 2022
Merged

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Feb 6, 2022

Resolves brave/brave-browser#18493

image

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Go to brave://ipfs page, start node and check if ipfs client updater version is present

@spylogsster spylogsster self-assigned this Feb 6, 2022
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Feb 6, 2022
@spylogsster spylogsster changed the title Add IPFS updater version to brave://ipfs page WIP: Add IPFS updater version to brave://ipfs page Feb 6, 2022
@spylogsster spylogsster changed the title WIP: Add IPFS updater version to brave://ipfs page Add IPFS updater version to brave://ipfs page Feb 6, 2022
@spylogsster spylogsster marked this pull request as ready for review February 6, 2022 19:28
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

#include "brave/components/ipfs/ipfs_service.h"
#include "brave/components/ipfs/repo_stats.h"
#include "brave/components/ipfs_ui/resources/grit/ipfs_generated_map.h"
#include "chrome/browser/browser_process_impl.h"
#include "components/component_updater/component_updater_service.h"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need a dependency added in browser/ui/BUILD.gn for components/component_updater

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@spylogsster spylogsster merged commit afa2d78 into master Feb 7, 2022
@spylogsster spylogsster deleted the issue-18493 branch February 7, 2022 20:44
@spylogsster spylogsster added this to the 1.37.x - Nightly milestone Feb 7, 2022
muliswilliam pushed a commit that referenced this pull request Feb 8, 2022
* Add IPFS updater version to brave://ipfs page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
3 participants