Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various fixes for Android EVM networks feature (uplift to 1.36.x) #12213

Merged
merged 1 commit into from
Feb 14, 2022
Merged

Various fixes for Android EVM networks feature (uplift to 1.36.x) #12213

merged 1 commit into from
Feb 14, 2022

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Feb 10, 2022 •
edited by kjozwiak

Uplift of #12204
Resolves brave/brave-browser#20968
Resolves brave/brave-browser#20962
Resolves brave/brave-browser#20967
Resolves brave/brave-browser#20977

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team February 10, 2022 16:22
@brave-builds brave-builds self-assigned this Feb 10, 2022
@brave-builds brave-builds added this to the 1.36.x - Beta milestone Feb 10, 2022
kjozwiak
kjozwiak approved these changes Feb 14, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.36.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #12204 (comment) & #12204 (comment).

@kjozwiak kjozwiak merged commit a2c4042 into 1.36.x Feb 14, 2022
@kjozwiak kjozwiak deleted the pr12204_android_evm_fixes_1.36.x branch February 14, 2022 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.36.x - Release
3 participants
@brave-builds @kjozwiak @brave-browser-releases