Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button text at the bottom of custom network form is cut off #20962

Closed
Uni-verse opened this issue Feb 8, 2022 · 6 comments · Fixed by brave/brave-core#12204
Closed

Button text at the bottom of custom network form is cut off #20962

Uni-verse opened this issue Feb 8, 2022 · 6 comments · Fixed by brave/brave-core#12204
Assignees
Labels
android-phone-specific bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/include

Comments

@Uni-verse
Copy link
Contributor

Description

Button text at the bottom of add custom network form is cut off/misaligned

Steps to reproduce

  1. Tap menu > settings
  2. Select Brave Wallet
  3. Create wallets, skip back up
  4. From the wallet dashboard, access the settings menu
  5. Select Networks
  6. Select + Add Network
  7. Observe the button of the add network form

Actual result

'Add' button text is slightly cut off

Screenshot_20220208-054629_Brave - Beta

Expected result

Text should not be cut off

Issue reproduces how often

Easily

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version?

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Samsung GS 21
  • Android version: Android 12

Brave version

1.36.83, Chromium 98.0.4758.87

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@Uni-verse Uni-verse added bug QA/Yes feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Feb 8, 2022
@srirambv srirambv added this to Untriaged in Wallet via automation Feb 8, 2022
@srirambv srirambv added this to Backlog in Android General via automation Feb 8, 2022
@srirambv
Copy link
Contributor

srirambv commented Feb 8, 2022

Can only repro this when the default display size is set to large and font size is set to max. Problem in such case is the Add/submit button is not at all shown. @Uni-verse can you check if the display is default or large on your device?

Default display & font Font size set to Max Display size set to max
image image image

@srirambv
Copy link
Contributor

srirambv commented Feb 8, 2022

cc: @wchen342 @Pavneet-Sing

@Pavneet-Sing
Copy link

Pavneet-Sing commented Feb 8, 2022

I am seeing the issue on my emulator without any display and font changes.

issue settings
Screenshot from 2022-02-08 23-04-32 Screenshot from 2022-02-08 23-07-18

@SergeyZhukovsky SergeyZhukovsky self-assigned this Feb 9, 2022
@SergeyZhukovsky SergeyZhukovsky moved this from Untriaged to In progress in Wallet Feb 9, 2022
Wallet automation moved this from In progress to Closed Feb 10, 2022
Android General automation moved this from Backlog to Done/Closed Feb 10, 2022
@SergeyZhukovsky SergeyZhukovsky added this to the 1.37.x - Nightly milestone Feb 10, 2022
@Uni-verse
Copy link
Contributor Author

Uni-verse commented Feb 11, 2022

Verification completed using Nightly 1.37.42, Chromium 98.0.4758.87
Device: Samsung GS 21 | Android 12

Issue has been resolved

  • Button text has enough padding around it.

Screenshot_20220211-232400_Brave - Nightly

@Uni-verse
Copy link
Contributor Author

Can only repro this when the default display size is set to large and font size is set to max. Problem in such case is the Add/submit button is not at all shown. @Uni-verse can you check if the display is default or large on your device?

Default display & font Font size set to Max Display size set to max
image image image

Sorry @srirambv i missed your question earlier but i'm pretty confident that its all set on default. Im sure both are original settings.

1 2
Screen Shot 2022-02-24 at 12 16 46 PM Screen Shot 2022-02-24 at 12 16 00 PM

@Uni-verse
Copy link
Contributor Author

Uni-verse commented Feb 24, 2022

Verification completed on release branch 1.36.105, Chromium 99.0.4844.45

PASSED on Samsung Galaxy S21 | Android 12 | ARM

  • Button text is no longer cut off on the 'Add Network' page form
  • Button padding is sufficient to accommodate larger fonts
Default font Larger Font
Screen Shot 2022-02-24 at 12 22 27 PM Screen Shot 2022-02-24 at 12 22 52 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android-phone-specific bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/include
Projects
Android General
  
Done/Closed
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants