-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Brave news - ui fixes #12908
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
android/java/org/chromium/chrome/browser/ntp/BraveNewTabPageLayout.java
Outdated
Show resolved
Hide resolved
android/java/org/chromium/chrome/browser/ntp/BraveNewTabPageLayout.java
Outdated
Show resolved
Hide resolved
android/java/org/chromium/chrome/browser/ntp/BraveNewTabPageLayout.java
Outdated
Show resolved
Hide resolved
android/java/org/chromium/chrome/browser/ntp/BraveNewTabPageLayout.java
Outdated
Show resolved
Hide resolved
3de9e1e
to
8065ccd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks 👍
|
Created a follow up via brave/brave-browser#22356 to improve Android keeping the correct position with the Brave News feed when switching tabs. |
Resolves brave/brave-browser#21868
Resolves brave/brave-browser#20580
Resolves brave/brave-browser#21873
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: