Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed inactive tab color is unreadable with accent color #12946

Merged
merged 1 commit into from
Apr 8, 2022

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Apr 8, 2022

fix brave/brave-browser#22027

As we don't use accent color for title bar, tab color should not be
affected also by accent color.
Fixed by preventing Windows' accent color affect frame colors.

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See the linked issue.

fix brave/brave-browser#22027

As we don't use accent color for title bar, tab color should not be
affected also by accent color.
Fixed by preventing Windows' accent color affect frame colors.
@simonhong simonhong requested a review from a team as a code owner April 8, 2022 04:33
@simonhong simonhong self-assigned this Apr 8, 2022
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kjozwiak
Copy link
Member

kjozwiak commented Apr 12, 2022

Reproduced the original issue on Win 11 x64 using the following build(s):

Brave | 1.37.111 Chromium: 100.0.4896.79 (Official Build) (64-bit)
-- | --
Revision | 8fb749dcab8700c24213791969e59deb72fee36f-refs/branch-heads/4896@{#1015}
OS | Windows 11 Version 21H2 (Build 22000.593)

Dark Theme

Example Example
winSettings reproducedDark

Light Theme

Example Example
winSettingsStorm reproducedLight

Verification PASSED on Win 11 x64 using the following build(s):

-- | --
Revision | 8fb749dcab8700c24213791969e59deb72fee36f-refs/branch-heads/4896@{#1015}
OS | Windows 11 Version 21H2 (Build 22000.593)

Dark Theme

Example Example
winSettings image

Light Theme

Example Example
winSettingsStorm image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants