Reverts Chromium's [Clipboard API] Remove user gesture requirement fo…

[mkarolin]

…r read/writeText.

We should not relax the gesture requirement.

Chromium change:

https://chromium.googlesource.com/chromium/src/+/4d7b74b051abfe5945f418601fdc2ffc8ce3072c

commit 4d7b74b051abfe5945f418601fdc2ffc8ce3072c
Author: Anupam Snigdha snianu@microsoft.com
Date: Tue Jun 7 16:36:28 2022 +0000

[Clipboard API] Remove user gesture requirement for read/writeText.

Adding user gesture requirement for readText and writeText APIs
breaks NTP doodle sharing. We are relaxing this check for now, but
we should fix this for sites to not rely on these APIs to be called
without a user gesture.
See NewTabPageDoodleShareDialogFocusTest.All test for more details.

Bug: 106449, 1334203

Resolves brave/brave-brwoser#16890
(It doesn't strictly address the original issue, because Chromium's initial implementation before the above change does require a gesture already.)

Submitter Checklist:

• I confirm that no security/privacy review is needed, or that I have requested one
• There is a ticket for my issue
• Used Github auto-closing keywords in the PR description above
• Wrote a good PR/commit description
• Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
• Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
• Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
• Ran git rebase master (if needed)

Reviewer Checklist:

• A security review is not needed, or a link to one is included in the PR description
• New files have MPL-2.0 license header
• Adequate test coverage exists to prevent regressions
• Major classes, functions and non-trivial code blocks are well-commented
• Changes in component dependencies are properly reflected in gn
• Code follows the style guide
• Test plan is specified in PR before merging

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on
• All relevant documentation has been updated, for instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
  • https://github.com/brave/brave-browser/wiki/QA-Guide
  • https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

1. Visit https://shivankaul.com/brave/clipboard-paste.html
2. You should see a message like:

   This page will attempt to write text to your clipboard without a permission prompt or user interaction.
   SecurityError: Must be handling a user gesture to use custom clipboard
   

3. Reload the page a few times
4. Verify you still don't see a success message

[bsclifton]

npm run lint found some errors but I think we're fine committing with them (we could add // NOLINT, but not worth it IMO)

[2022-08-30T19:36:17.611Z] chromium_src/third_party/blink/renderer/modules/clipboard/clipboard_promise.cc:10:  (cpplint) Weird number of spaces at line-start.  Are you using a 2-space indent?  [whitespace/indent] [3]
[2022-08-30T19:36:17.611Z] chromium_src/third_party/blink/renderer/modules/clipboard/clipboard_promise.cc:10:  (cpplint) Missing space before ( in if(  [whitespace/parens] [5]

Building now to give it a try 😄

[goodov]

lgtm, but imo quite unclear change for a pretty critical issue.

maybe just add our own block to prevent any clipboard interaction without user gesture? (and add test?)

  if (!has_transient_user_activation) {
    script_promise_resolver_->Reject(MakeGarbageCollected<DOMException>(
        DOMExceptionCode::kSecurityError,
        "Must be handling a user gesture to use clipboard"));
    return;
  }

[mkarolin]

@goodov agree that we may want to add our check, but I'd prefer to limit this fix to just reverting the Chromium's temporary(?) relaxation of the gesture requirement. @ShivanKaul do we need a follow up issue to consider adding our own restriction here as @goodov suggesting?

[bsclifton]

NOTE: we'll want to update https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove) when we merge

[mkarolin]

Force pushed the fix for the lint error.

[kjozwiak]

Reproduced the issue on Win 11 x64 using the following build(s):

Brave | 1.45.14 Chromium: 105.0.5195.68 (Official Build) nightly (64-bit)
--- | ---
Revision | ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
OS | Windows 11 Version 21H2 (Build 22000.918)

Went through the STR/Cases outlined via #14901 (comment) and reproduced the original issue as per the following:

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.45.30 Chromium: 105.0.5195.102 (Official Build) nightly (64-bit)
-- | --
Revision | 4c16f5ffcc2da70ee2600d5db77bed423ac03a5a-refs/branch-heads/5195_55@{#4}
OS | Windows 11 Version 21H2 (Build 22000.918)

Went through the STR/Cases outlined via #14901 (comment) and ensured that a Success message wasn't being displayed. Also opened several tabs and ensured the following message only appeared:

SecurityError: Must be handling a user gesture to use custom clipboard

Note: You may see a Not Allowed message which is fine as well as long as we don't see a Success.