Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rewards] Do not start utility process until user opts in. #15146

Merged
merged 5 commits into from
Oct 5, 2022
Merged

[Rewards] Do not start utility process until user opts in. #15146

merged 5 commits into from
Oct 5, 2022

Commits on Oct 4, 2022

  1. [Rewards] Do not start utility process until user opted in. 

    This change splits onboarding UI out of the settings so that we can show
onboarding without starting the utility process needed for the settings.

It also splits out the tour UI code because it's used in both onboarding
and settings.

Additionally, in the rewards service StartLedgerIfNecessary only starts
the utility process when rewards are "enabled". Creating a wallet starts
the utility process unconditionally as this is now the equivaling of
opting in.
    @mkarolin
    mkarolin committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    32a8bbe View commit details
    Browse the repository at this point in the history

  2. [Rewards] Remove StartProcess from rewards service public API.

    @mkarolin
    mkarolin committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    9ccb9f4 View commit details
    Browse the repository at this point in the history

  3. Lint fixes.

    @mkarolin
    mkarolin committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    e91e41f View commit details
    Browse the repository at this point in the history

  4. [Rewards] fixes rewards-internals page.

    @mkarolin
    mkarolin committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    45b82cf View commit details
    Browse the repository at this point in the history

  5. Ensure ledger process is started in ads service tests.

    @mkarolin
    mkarolin committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    39b459b View commit details
    Browse the repository at this point in the history