Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rewards] Do not start utility process until user opts in. #15146

Merged
merged 5 commits into from
Oct 5, 2022
Merged

[Rewards] Do not start utility process until user opts in. #15146

merged 5 commits into from
Oct 5, 2022

Conversation

mkarolin
Copy link
Collaborator

Resolves brave/brave-browser#14277

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin requested a review from a team as a code owner September 20, 2022 20:30
@mkarolin mkarolin self-assigned this Sep 20, 2022
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Sep 20, 2022
@mkarolin mkarolin changed the title [Rewards] Do not start utility process until user opts in. WIP: [Rewards] Do not start utility process until user opts in. Sep 20, 2022
@mkarolin mkarolin force-pushed the maxk-rewards-net-reqs-before-opt-in branch from a2b4924 to 487c47a Compare September 20, 2022 21:05
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@mkarolin mkarolin force-pushed the maxk-rewards-net-reqs-before-opt-in branch from 487c47a to 1b3bf9c Compare September 22, 2022 17:57
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

1 similar comment
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@mkarolin mkarolin force-pushed the maxk-rewards-net-reqs-before-opt-in branch from b71ee85 to a367b78 Compare September 23, 2022 22:27
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@mkarolin mkarolin requested a review from a team as a code owner September 26, 2022 14:05
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

tmancey
tmancey approved these changes Sep 26, 2022
View reviewed changes
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please see comment. Thanks

browser/brave_ads/ads_service_browsertest.cc Outdated Show resolved Hide resolved
@mkarolin mkarolin force-pushed the maxk-rewards-net-reqs-before-opt-in branch from 5e9c18d to 82821f3 Compare September 26, 2022 17:40
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@mkarolin mkarolin force-pushed the maxk-rewards-net-reqs-before-opt-in branch from 82821f3 to 0f1e99a Compare September 26, 2022 19:43
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@mkarolin mkarolin force-pushed the maxk-rewards-net-reqs-before-opt-in branch from cb589ea to 7ab7382 Compare September 26, 2022 22:36
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@mkarolin mkarolin added the CI/run-network-audit Run network-audit label Sep 27, 2022
@mkarolin mkarolin force-pushed the maxk-rewards-net-reqs-before-opt-in branch from 7ab7382 to 82e655e Compare September 27, 2022 16:06
@mkarolin mkarolin changed the title WIP: [Rewards] Do not start utility process until user opts in. [Rewards] Do not start utility process until user opts in. Sep 27, 2022
@mkarolin mkarolin force-pushed the maxk-rewards-net-reqs-before-opt-in branch from 82e655e to b5db45b Compare September 27, 2022 16:32
@mkarolin mkarolin force-pushed the maxk-rewards-net-reqs-before-opt-in branch from b5db45b to 8bb5696 Compare September 27, 2022 17:15
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@mkarolin mkarolin force-pushed the maxk-rewards-net-reqs-before-opt-in branch from 8bb5696 to a65ccdd Compare October 3, 2022 19:09
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@mkarolin
[Rewards] Do not start utility process until user opted in.
32a8bbe 
This change splits onboarding UI out of the settings so that we can show
onboarding without starting the utility process needed for the settings.

It also splits out the tour UI code because it's used in both onboarding
and settings.

Additionally, in the rewards service StartLedgerIfNecessary only starts
the utility process when rewards are "enabled". Creating a wallet starts
the utility process unconditionally as this is now the equivaling of
opting in.
@mkarolin
[Rewards] Remove StartProcess from rewards service public API.
9ccb9f4
@mkarolin
Lint fixes.
e91e41f
@mkarolin
[Rewards] fixes rewards-internals page.
45b82cf
@mkarolin
Ensure ledger process is started in ads service tests.
39b459b
@mkarolin mkarolin force-pushed the maxk-rewards-net-reqs-before-opt-in branch from e63215c to 39b459b Compare October 4, 2022 02:37
@mkarolin
Copy link
Collaborator Author

mkarolin commented Oct 4, 2022

Rebased on master and squashed fixups

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@iefremov
Copy link
Contributor

iefremov commented Oct 5, 2022

browser/net/* lgtm

@mkarolin mkarolin merged commit 36e2c18 into master Oct 5, 2022
@mkarolin mkarolin deleted the maxk-rewards-net-reqs-before-opt-in branch October 5, 2022 15:08
@mkarolin mkarolin added this to the 1.46.x - Nightly milestone Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmancey tmancey tmancey approved these changes

@iefremov iefremov iefremov approved these changes

@zenparsing zenparsing zenparsing approved these changes

Assignees

@mkarolin mkarolin

Labels
CI/run-network-audit Run network-audit CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
1.46.x - Release
5 participants
@mkarolin @brave-builds @iefremov @tmancey @zenparsing