Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search onboarding exception for BR and AR #15783

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

deeppandya
Copy link
Contributor

Resolves brave/brave-browser#26318

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@deeppandya deeppandya added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Nov 3, 2022
@deeppandya deeppandya added this to the 1.47.x - Nightly milestone Nov 3, 2022
@deeppandya deeppandya self-assigned this Nov 3, 2022
Copy link
Contributor

@sujitacharya2005 sujitacharya2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Copy link
Contributor

@tapanmodh tapanmodh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deeppandya deeppandya merged commit 9fb1f0c into master Nov 3, 2022
@deeppandya deeppandya deleted the remove_search_onboarding_for_br_ar branch November 3, 2022 21:30
brave-builds pushed a commit that referenced this pull request Nov 3, 2022
brave-builds pushed a commit that referenced this pull request Nov 3, 2022
@kjozwiak
Copy link
Member

kjozwiak commented Nov 4, 2022

Verification PASSED on Samsung Galaxy S10+ running Android 12 using the following build(s):

Brave | 1.47.46 Chromium: 107.0.5304.91 (Build oficial) canary (32 bits)
--- | ---
Revision | 3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097}
OS | Android 12; Build/SP1A.210812.016

BR (Brazil) locale (new addition)

Onboarding remove (added into exception list)
  • ensured that the default SE for Normal windows is set as Brave
  • ensured that the default SE for Private windows is set as Brave
  • ensured that tapping on the URL doesn't display the SE onboarding modal (need to tap on the URL on two occasions)
Example Example Example Example
Screenshot_20221104-152920_Settings Screenshot_20221104-152048_Brave - Nightly Screenshot_20221104-152052_Brave - Nightly Screenshot_20221104-152057_Brave - Nightly

AR (Argentina) locale (new addition)

Onboarding remove (added into exception list)
  • ensured that the default SE for Normal windows is set as Brave
  • ensured that the default SE for Private windows is set as Brave
  • ensured that tapping on the URL doesn't display the SE onboarding modal (need to tap on the URL on two occasions)
Example Example Example Example
Screenshot_20221104-152936_Settings Screenshot_20221104-153403_Brave - Nightly Screenshot_20221104-153407_Brave - Nightly Screenshot_20221104-153411_Brave - Nightly

FR (France) locale (existing locale with Brave Search as default)

Onboarding remove (added into exception list)
  • ensured that the default SE for Normal windows is set as Brave
  • ensured that the default SE for Private windows is set as Brave
  • ensured that tapping on the URL doesn't display the SE onboarding modal (need to tap on the URL on two occasions)
Example Example Example Example
Screenshot_20221104-153752_Settings Screenshot_20221104-153843_Brave - Nightly Screenshot_20221104-153847_Brave - Nightly Screenshot_20221104-153851_Brave - Nightly

PL (Poland) locale (doesn't have Brave Search as default)

Onboarding remove (added into exception list)
  • ensured that the default SE for Normal windows is set as Google
  • ensured that the default SE for Private windows is set as Google
  • ensured that tapping on the URL on the second attempt displays the SE onboarding modal without issues
  • ensured that Google is selected as the default SE via the onboarding modal
  • ensured that both Normal & Private are updated correctly if another SE is selected from the onboarding modal
Example Example Example Example Example
Screenshot_20221104-154430_Settings Screenshot_20221104-152219_Brave - Nightly Screenshot_20221104-152234_Brave - Nightly Screenshot_20221104-152238_Brave - Nightly Screenshot_20221104-152242_Brave - Nightly

Selecting another SE from the onboarding and ensuring Normal & Private windows were updated

Example Example Example Example
Screenshot_20221104-154652_Brave - Nightly Screenshot_20221104-154700_Brave - Nightly Screenshot_20221104-154708_Brave - Nightly Screenshot_20221104-154704_Brave - Nightly

RU (Russia) locale (Yandex as the default SE)

Onboarding remove (added into exception list)
  • ensured that the default SE for Normal windows is set as Yandex
  • ensured that the default SE for Private windows is set as Yandex
  • ensured that tapping on the URL on the second attempt displays the SE onboarding modal without issues
  • ensured that Google is selected as the default SE via the onboarding modal
  • ensured that both Normal & Private are updated correctly if another SE is selected from the onboarding modal
Example Example Example Example Example
Screenshot_20221104-155058_Settings Screenshot_20221104-155108_Brave - Nightly Screenshot_20221104-155258_Brave - Nightly Screenshot_20221104-155122_Brave - Nightly Screenshot_20221104-155127_Brave - Nightly

Selecting another SE from the onboarding and ensuring Normal & Private windows were updated

Example Example Example Example
Screenshot_20221104-155310_Brave - Nightly Screenshot_20221104-155323_Brave - Nightly Screenshot_20221104-155326_Brave - Nightly Screenshot_20221104-155329_Brave - Nightly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
5 participants