Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ESLint]: Add ESLint license check. #15817

Merged
merged 11 commits into from
Nov 9, 2022
Merged

[ESLint]: Add ESLint license check. #15817

merged 11 commits into from
Nov 9, 2022

Conversation

fallaciousreasoning
Copy link
Contributor

@fallaciousreasoning fallaciousreasoning commented Nov 6, 2022

Resolves brave/brave-browser#26575

Submitter Checklist:

  • I have requested a security & privacy review here
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

@fmarier
Copy link
Member

fmarier commented Nov 7, 2022

While we haven't been doing that consistently at Brave, the correct headers now use the HTTPS URL:

 * file, You can obtain one at https://mozilla.org/MPL/2.0/.

So I'd suggest this:

  1. we accept both in the check
  2. we add the HTTPS URL for all of the missing headers we add

Instead of #1, we could also just upgrade the existing ones, but that's not really necessary.

.eslintrc.json Outdated Show resolved Hide resolved
@fallaciousreasoning
Copy link
Contributor Author

@fmarier it should use https urls now, and I updated the tool to inject the year the file was added to source control. I haven't bothered rebasing onto master so there are a bunch of conflicts, as I think we're still a little way off merging it (pending security review ect).

@fallaciousreasoning
Copy link
Contributor Author

fallaciousreasoning commented Nov 7, 2022

@petemill for @brave/js-deps-reviewers
@emerick for @brave/rewards-client
@onyb for @brave/crypto-wallets-front-end
@jamesmudgett for @brave/crypto-wallets & @brave/ios

The changes to the files in rewards-client & crypto-wallets-front-end should just be updating or adding missing license headers.

Note: The build is failing for merge conflicts - I'm not going to fix them until we're ready to land this as we keep getting new ones.

@petemill
Copy link
Member

petemill commented Nov 8, 2022

We can probably bypass most of those owner reviews since we're not making any code changes.

package-lock.json Outdated Show resolved Hide resolved
Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this complex issue and writing an eslint plugin from scratch to accomplish it! Nice work. Hope the rebase isn't too bad.

@bsclifton
Copy link
Member

Doing an admin merge - things should be good to go and there are just too many reviewer groups (as this touches a lot of files; but only licensing).

@bsclifton bsclifton merged commit 22f198e into master Nov 9, 2022
@bsclifton bsclifton deleted the eslint-license branch November 9, 2022 08:15
@github-actions github-actions bot added this to the 1.47.x - Nightly milestone Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants