Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): Account Name Wrapping in Send Tab #16075

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

Douglashdaniel
Copy link
Contributor

Description

Fixes a bug where long Account names were wrapping in the Send tab.

Resolves brave/brave-browser#26958

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Make a long Account name.
  2. Go to brave://wallet/send and select a token for that account.
  3. The Account name and Balance should not wrap.

Before:

Screen Shot 2022-11-23 at 4 15 41 PM

After:

Screen Shot 2022-11-23 at 4 09 42 PM

@Douglashdaniel Douglashdaniel self-assigned this Nov 23, 2022
@Douglashdaniel Douglashdaniel requested a review from a team as a code owner November 23, 2022 22:16
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Nov 23, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Member

@onyb onyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@Douglashdaniel Douglashdaniel merged commit 9a13fb5 into master Nov 28, 2022
@Douglashdaniel Douglashdaniel deleted the fix-account-name-wrapping-send-tab branch November 28, 2022 01:51
@github-actions github-actions bot added this to the 1.48.x - Nightly milestone Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
3 participants