Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet): Add Loading State for Domain Lookup #16127

Merged
merged 1 commit into from Nov 29, 2022

Conversation

Douglashdaniel
Copy link
Contributor

Description

Adds a Loading State while our API resolves domains

Resolves brave/brave-browser#26956

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Go to brave://wallet/send
  2. In the Enter recipient address field, enter a UD, ENS or SNS domain
  3. There should be loading state while the address is being resolved by our API
Screen.Recording.2022-11-28.at.11.00.17.PM.mov

@Douglashdaniel Douglashdaniel requested review from a team as code owners November 29, 2022 05:09
@Douglashdaniel Douglashdaniel self-assigned this Nov 29, 2022
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Nov 29, 2022
Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backend++

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Member

@onyb onyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@Douglashdaniel Douglashdaniel merged commit 195940e into master Nov 29, 2022
@Douglashdaniel Douglashdaniel deleted the add-loading-state-for-domain-lookup branch November 29, 2022 16:10
@github-actions github-actions bot added this to the 1.48.x - Nightly milestone Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
4 participants