Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS - Uplift - 1.48.x] - URLFormatter Export Options #16678

Merged
merged 1 commit into from Jan 19, 2023

Conversation

Brandon-T
Copy link
Contributor

@Brandon-T Brandon-T commented Jan 14, 2023

Uplift of: #16677
Resolves https://github.com/brave/internal/issues/991

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@Brandon-T Brandon-T added CI/skip-android Do not run CI builds for Android CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Jan 14, 2023
@Brandon-T Brandon-T added this to the 1.48.x - Beta milestone Jan 14, 2023
@Brandon-T Brandon-T self-assigned this Jan 14, 2023
@Brandon-T Brandon-T requested a review from a team as a code owner January 14, 2023 03:47
@github-actions
Copy link
Contributor

⚠️ PR head is an unsigned commit
commit: 1d20c54
reason: unsigned
Please follow the handbook to configure commit signing
cc: @Brandon-T

@Brandon-T Brandon-T force-pushed the uplift-ios-url-format-options-1.48.x branch from 1d20c54 to e228048 Compare January 17, 2023 22:56
@Brandon-T Brandon-T force-pushed the uplift-ios-url-format-options-1.48.x branch from e228048 to 9a42104 Compare January 18, 2023 19:18
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.48.x approved 👍

@kjozwiak kjozwiak merged commit 85504f9 into 1.48.x Jan 19, 2023
@kjozwiak kjozwiak deleted the uplift-ios-url-format-options-1.48.x branch January 19, 2023 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
2 participants