Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show SOL Send transaction receiving address #16879

Merged
merged 1 commit into from Jan 26, 2023

Conversation

josheleonard
Copy link
Collaborator

@josheleonard josheleonard commented Jan 26, 2023

Resolves brave/brave-browser#28039

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Submit a send transaction on Solana
  2. Open panel and navigate to Transaction history
  3. Account name or actual Receiving address is shown

@josheleonard josheleonard requested a review from a team as a code owner January 26, 2023 17:39
@josheleonard josheleonard self-assigned this Jan 26, 2023
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Jan 26, 2023
Copy link
Contributor

@Douglashdaniel Douglashdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@josheleonard josheleonard merged commit 995eb50 into master Jan 26, 2023
@josheleonard josheleonard deleted the fix-show-solana-transaction-to-address branch January 26, 2023 23:38
@github-actions github-actions bot added this to the 1.49.x - Nightly milestone Jan 26, 2023
kjozwiak pushed a commit that referenced this pull request Feb 6, 2023
…x) (#17027)

fix: show SOL Send transaction receiving address (#16879)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
3 participants