Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arbitrary release notes via regex #17226

Merged
merged 2 commits into from
Feb 15, 2023
Merged

Conversation

kim0
Copy link
Contributor

@kim0 kim0 commented Feb 15, 2023

Resolves https://github.com/brave/devops/issues/9156

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Signed-off-by: Ahmed Kamal <email.ahmedkamal@googlemail.com>
@kim0 kim0 added the CI/skip Do not run CI builds (except noplatform) label Feb 15, 2023
@kim0 kim0 requested a review from mihaiplesa February 15, 2023 09:45
@kim0 kim0 self-assigned this Feb 15, 2023
@kim0
Copy link
Contributor Author

kim0 commented Feb 15, 2023

The previous approach was parsing MD into AST, zooming in on the interesting lines, then somewhat struggle to convert the AST back into MD. This is mainly bec the parsing engine does not have proper markdown-to-markdown converter. Since we need to support more complex/arbitrary markdown in release notes, and the input is already markdown, i.e. no conversion really needed. This PR simply uses regex to snip the interesting part and passes it as output directly.

@kim0 kim0 enabled auto-merge (squash) February 15, 2023 09:59
Signed-off-by: Ahmed Kamal <email.ahmedkamal@googlemail.com>
@mihaiplesa mihaiplesa merged commit 70309e2 into master Feb 15, 2023
@mihaiplesa mihaiplesa deleted the aka/handle-arbitrary-release-notes branch February 15, 2023 10:40
@github-actions github-actions bot added this to the 1.50.x - Nightly milestone Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip Do not run CI builds (except noplatform)
Projects
None yet
2 participants