Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] restore support for JPEG XL #17721

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[WIP] restore support for JPEG XL #17721

wants to merge 1 commit into from

Conversation

antonok-edm
Copy link
Collaborator

@antonok-edm antonok-edm commented Mar 23, 2023

Resolves brave/brave-browser#28411

note: this PR is currently intended as exploratory work. The changes here were manually applied from Alex313031/thorium-libjxl, although successfully merging them with Brave's own patches required some intervention.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Confirm that the JPEG XL images on https://jpegxl.info/test-page/ are visible.

@mihaiplesa mihaiplesa added the CI/skip Do not run CI builds (except noplatform) label Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip Do not run CI builds (except noplatform)
Projects
None yet
2 participants