Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display wallet icon when viewing brave, add button in wallet to open a tab to brave://wallet/swap #17947

Merged

Conversation

vadimstruts
Copy link
Collaborator

@vadimstruts vadimstruts commented Apr 6, 2023

  • Implemented the possibility to open android wallet confirmation window automatically if swap operation initiated.
  • Added wallet icon to the URL bar, when visiting brave://wallet/swap
  • The android wallet's swap button will open the new tab with brave://wallet/swap URL, instead of native android swap activity

Resolves brave/brave-browser#29221
Resolves brave/brave-browser#29222
Resolves brave/brave-browser#29223

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a tickets 29221, 29222, 29223 for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@vadimstruts vadimstruts force-pushed the 29221-display-wallet-icon-when-viewing-bravewalletswap branch from bdd4273 to a4ba63f Compare April 7, 2023 10:30
@vadimstruts vadimstruts marked this pull request as ready for review April 7, 2023 12:58
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Signed-off-by: Vadym Struts <vstruts@brave.com>
@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 13 running 1.52.40 x64 Nightly build

  • Verified able to visit brave://wallet/swap and is immediately connected to the wallet network
  • Verified wallet icon is always shown on visiting brave://wallet/swap
  • Verified selecting Swap from token details page or from action button loads a new tab and loads brave://wallet/swap
  • Verified if there is already an opened swap page, focus is set to it rather than opening a new tab
  • Encountered #29680, #29681 & #29682
17947.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet/core feature/web3/wallet potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false
Projects
None yet
3 participants