Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Leo]: Enable Leo in Polymer, and convert settings page #18156

Merged
merged 16 commits into from
May 30, 2023
Merged

[Leo]: Enable Leo in Polymer, and convert settings page #18156

merged 16 commits into from
May 30, 2023

Conversation

fallaciousreasoning
Copy link
Contributor

@fallaciousreasoning fallaciousreasoning commented Apr 20, 2023 •
edited

Resolves brave/brave-browser#30051

This unblocks #16388, where our polymer overriding of iron-icons gets broken.

WAITING ON brave/leo#285

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@github-actions github-actions bot added CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/storybook-url Deploy storybook and provide a unique URL for each build labels Apr 20, 2023
@fallaciousreasoning fallaciousreasoning changed the base branch from master to dl-progressbar April 20, 2023 03:59
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Base automatically changed from dl-progressbar to master April 20, 2023 05:09
@fallaciousreasoning fallaciousreasoning marked this pull request as ready for review April 28, 2023 00:34
@fallaciousreasoning fallaciousreasoning requested a review from a team as a code owner April 28, 2023 00:34
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@fallaciousreasoning fallaciousreasoning requested a review from a team as a code owner April 30, 2023 21:39
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

goodov
goodov approved these changes May 1, 2023
View reviewed changes
Copy link
Member

@goodov goodov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with few nits.

patches/ui-webui-resources-tools-optimize_webui.py.patch Outdated Show resolved Hide resolved
chromium_src/ui/webui/resources/tools/optimize_webui.py Outdated Show resolved Hide resolved
@fallaciousreasoning fallaciousreasoning mentioned this pull request May 2, 2023
Merged
25 tasks
@fallaciousreasoning fallaciousreasoning requested a review from a team as a code owner May 3, 2023 23:29
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@fallaciousreasoning fallaciousreasoning mentioned this pull request May 8, 2023
Merged
@fallaciousreasoning fallaciousreasoning changed the base branch from master to bump-leo May 25, 2023 03:59
Base automatically changed from bump-leo to master May 25, 2023 04:13
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@fallaciousreasoning fallaciousreasoning merged commit 62d74d5 into master May 30, 2023
16 checks passed
@fallaciousreasoning fallaciousreasoning deleted the dl-leo branch May 30, 2023 21:33
@github-actions github-actions bot added this to the 1.54.x - Nightly milestone May 30, 2023
@github-actions github-actions bot removed the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goodov goodov goodov approved these changes

@petemill petemill petemill approved these changes

Assignees

@fallaciousreasoning fallaciousreasoning

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
1.57.x - Release
4 participants
@fallaciousreasoning @brave-builds @petemill @goodov