Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove widget promo #18638

Merged
merged 1 commit into from
May 26, 2023
Merged

Remove widget promo #18638

merged 1 commit into from
May 26, 2023

Conversation

deeppandya
Copy link
Contributor

Resolves brave/brave-browser#30618

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@deeppandya deeppandya added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x86 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 labels May 26, 2023
@deeppandya deeppandya added this to the 1.54.x - Nightly milestone May 26, 2023
@deeppandya deeppandya self-assigned this May 26, 2023
Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit dfc3d76 into master May 26, 2023
16 checks passed
@bsclifton bsclifton deleted the remove_widget_promo branch May 26, 2023 23:00
brave-builds added a commit that referenced this pull request May 26, 2023
brave-builds added a commit that referenced this pull request May 26, 2023
@kjozwiak
Copy link
Member

Verification PASSED on Pixel 6 running Android 14 using the following build(s):

Brave | 1.54.16 Chromium: 114.0.5735.53 (Official Build) canary (64-bit)
--- | ---
Revision | c499d7ea22c8b2dba278465a5df7b86a8efa4e64-refs/branch-heads/5735@{#970}
OS | Android 13; Build/UPB2.230407.014; 33; UpsideDownCake

Test Case #1 (opening tabs/restarting browser)

  • opened ~30 tabs and ensured that the OSK is being shown when tapping on the omnibox every single time
    • ensured that the Widget onboarding modal isn't triggered/appearing when tapping on the omnibox
    • after opening ~30 different tabs, restart the browser ~20 times and ensured that the Widget onboarding isn't displayed
    • ensured that you can still add a home widget via Hambruger Menu -> Settings -> Home screen widget
      • ensured that you can add other Brave widgets via Widgets on the Android Home screen
  • ensured that all the widgets are removed when Brave is uninstalled

Test Case #2 (restarting browser/opening tabs)

  • opened Brave ~30 times and ensured that the OSK is being shown when tapping on the omnibox every single time
    • ensured that the Widget onboarding modal isn't triggered/appearing when tapping on the omnibox
    • after opening Brave ~30 different times, opened ~20 tabs and ensured that the Widget onboarding isn't displayed
    • ensured that you can still add a home widget via Hambruger Menu -> Settings -> Home screen widget
      • ensured that you can add other Brave widgets via Widgets on the Android Home screen
  • ensured that all the widgets are removed when Brave is uninstalled

kjozwiak pushed a commit that referenced this pull request May 30, 2023
kjozwiak pushed a commit that referenced this pull request May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
6 participants