Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(wallet): improve panel performance #18735

Merged
merged 1 commit into from
Jun 7, 2023
Merged

chore(wallet): improve panel performance #18735

merged 1 commit into from
Jun 7, 2023

Conversation

onyb
Copy link
Member

@onyb onyb commented Jun 2, 2023

This PR contains the following perf improvements:

  1. Use optimised balance scanners for ERC20 and SPL tokens, whenever possible.
  2. Migrate panel to use the useGetTokenBalancesForChainIdQuery query hook.
    i. The panel no longer reads the balances from the legacy Redux store.
  3. Only fetch balances for selected account and network on the main page.
    i. Similar optimisation is done for the "account assets" panel screen.
  4. Prevent querying of balances on startup, and lazy-fetch it only after components that need balances have mounted.
    i. Similarly, balance refresh as a result of various panel actions have been removed.
  5. Use async.mapLimit to throttle concurrent promises performing HTTP requests.
    i. This maximum number of concurrent promises allowed is 10.
  6. Prevent a full refresh of balances when switching to a custom network.
    i. This is the result of a bug, but this is a good short-term solution for now.

Resolves brave/brave-browser#30772
Resolves brave/brave-browser#22714

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@onyb onyb self-assigned this Jun 2, 2023
@onyb onyb requested a review from a team as a code owner June 2, 2023 13:15
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet labels Jun 2, 2023
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Collaborator

@josheleonard josheleonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@onyb onyb enabled auto-merge (squash) June 6, 2023 18:22
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@onyb onyb merged commit a978f58 into master Jun 7, 2023
15 of 16 checks passed
@onyb onyb deleted the f/wallet/rapid-panel branch June 7, 2023 17:55
@github-actions github-actions bot added this to the 1.54.x - Nightly milestone Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet
Projects
None yet
3 participants