-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(wallet): improve panel performance #18735
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
f2d7b0b
to
4facee4
Compare
A Storybook has been deployed to preview UI for the latest push |
4facee4
to
5eb4f53
Compare
A Storybook has been deployed to preview UI for the latest push |
josheleonard
reviewed
Jun 5, 2023
josheleonard
requested changes
Jun 5, 2023
components/brave_wallet_ui/components/extension/assets-panel/index.tsx
Outdated
Show resolved
Hide resolved
components/brave_wallet_ui/common/slices/entities/blockchain-token.entity.ts
Outdated
Show resolved
Hide resolved
components/brave_wallet_ui/components/extension/assets-panel/index.tsx
Outdated
Show resolved
Hide resolved
5eb4f53
to
a49b8e3
Compare
A Storybook has been deployed to preview UI for the latest push |
josheleonard
approved these changes
Jun 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
a49b8e3
to
9775e5e
Compare
A Storybook has been deployed to preview UI for the latest push |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following perf improvements:
useGetTokenBalancesForChainIdQuery
query hook.i. The panel no longer reads the balances from the legacy Redux store.
i. Similar optimisation is done for the "account assets" panel screen.
i. Similarly, balance refresh as a result of various panel actions have been removed.
async.mapLimit
to throttle concurrent promises performing HTTP requests.i. This maximum number of concurrent promises allowed is
10
.i. This is the result of a bug, but this is a good short-term solution for now.
Resolves brave/brave-browser#30772
Resolves brave/brave-browser#22714
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: