Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed extension's newtab is not loaded when it's restored during the startup #18898

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Jun 14, 2023

fix brave/brave-browser#30890

As we sanitize serialzed navigation(#14603), encoded page state is empty for all chrome url.
So, new page state is created with virtual url when it's restored during the startup. ContentSerializedNavigationBuilder::ToNavigationEntry() set new page state if it's empty.
When new page state is created, navigation's virtual url is created.
If url is re-written when NavigationEntryImpl is created, that re-written url is ignored.
To fix this, including url info only for chrome url's encoded page state.

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

BraveSessionRestoreBrowserTest.Serialization
BraveContentSerializedNavigationDriverTest.*

  1. Install any NewTab extension such as https://chrome.google.com/webstore/detail/momentum/laookkfknpbbblfpciffpaejjkokdgca
  2. Create another NTP and check extension's NTP is loaded
  3. Relaunch and check that lastly opened NTP loaded extension's NTP

@simonhong simonhong self-assigned this Jun 14, 2023
@simonhong simonhong changed the title Fixed extension's newtab is not loaded when it's restored during the … Fixed extension's newtab is not loaded when it's restored during the startup Jun 14, 2023
@simonhong simonhong requested a review from bsclifton June 14, 2023 01:07
@simonhong simonhong force-pushed the fix_extention_ntp_not_loaded branch from 438e897 to 1b775f0 Compare June 14, 2023 06:18
…startup

fix brave/brave-browser#30890

As we sanitize serialzed navigation(brave/brave-browser#30890),
encoded page state is empty for all chrome url.
So, new page state is created with virtual url when it's restored during the startup.
ContentSerializedNavigationBuilder::ToNavigationEntry() set new page state if it's empty.
When new page state is created, navigation's virtual url is created.
If url is re-written when NavigationEntryImpl is created, that re-written url is ignored.
To fix this, including url info only for chrome url's encoded page state.
@simonhong simonhong force-pushed the fix_extention_ntp_not_loaded branch from 1b775f0 to 0f0b013 Compare June 14, 2023 06:24
@simonhong simonhong marked this pull request as ready for review June 14, 2023 07:32
@simonhong simonhong requested a review from a team as a code owner June 14, 2023 07:32
@simonhong simonhong merged commit cb409ba into master Jun 14, 2023
17 checks passed
@simonhong simonhong deleted the fix_extention_ntp_not_loaded branch June 14, 2023 10:04
@github-actions github-actions bot added this to the 1.54.x - Nightly milestone Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants