Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleard sensitive info from url before sending to wayback machine svc (uplift to 1.58.x) #19892

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Cleard sensitive info from url before sending to wayback machine svc (uplift to 1.58.x) #19892

merged 2 commits into from
Aug 30, 2023

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Aug 25, 2023 •
edited by kjozwiak

Uplift of #19780
Uplift of #19786
Resolves brave/brave-browser#32385
Resolves brave/brave-browser#32395

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner August 25, 2023 23:39
@brave-builds brave-builds self-assigned this Aug 25, 2023
@brave-builds brave-builds added this to the 1.58.x - Beta milestone Aug 25, 2023
@simonhong
Merge pull request #19786 from brave/wayback_url_sanitize
4579132 
Sanitized wayback url from wayback machine
kjozwiak
kjozwiak approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.58.x approved 👍 QA has verified the PR on Nightly as per #19780 (comment) & #19786 (comment).

@kjozwiak kjozwiak merged commit d9c6033 into 1.58.x Aug 30, 2023
10 checks passed
@kjozwiak kjozwiak deleted the pr19780_wayback_url_sanitizing_1.58.x branch August 30, 2023 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.58.x - Release
3 participants
@brave-builds @kjozwiak @simonhong