-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sanitized wayback url from wayback machine #19786
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix brave/brave-browser#32395 Only allow to load valid wayback url that has http/https scheme and valid wayback domain.
simonhong
force-pushed
the
wayback_url_sanitize
branch
from
August 21, 2023 00:35
7dc3f0d
to
f87849e
Compare
diracdeltas
approved these changes
Aug 21, 2023
simonhong
added a commit
that referenced
this pull request
Aug 25, 2023
Sanitized wayback url from wayback machine
simonhong
added a commit
that referenced
this pull request
Aug 25, 2023
Sanitized wayback url from wayback machine
This was referenced Aug 25, 2023
Merged
Verification PASSED on
Using the STR/Cases outlined via brave/brave-browser#32395 (comment), ensured that
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#32395
Only allow to load valid wayback url that has http/https scheme and valid wayback domain.
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
WaybackMachineURLFetcherUnitTest.WaybackURLSanitizeTest
See the linked issue for manual test.