Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance seeker on PIP window #21619

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Enhance seeker on PIP window #21619

merged 2 commits into from
Jan 22, 2024

Conversation

sangwoo108
Copy link
Contributor

  • Hide invalid timestamp
  • Hide seeker when mouse is not over the window
  • Enable seeking when the MediaSession is controllable
  • When seeker is overlapped with bottom resizable area, treat mouse events for seeker.
  • On left or right key pressed, seek back or forward 10 seconds.

Resolves brave/brave-browser#35409

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

* Hide invalid timestamp
* Hide seeker when mouse is not over the window
* Enable seeking when the MediaSession is controllable
* When seeker is overlapped with bottom resizable area, treat mouse
  events for seeker.
* On left or right key pressed, seek back or forward 10 seconds.
@sangwoo108 sangwoo108 marked this pull request as ready for review January 19, 2024 13:43
@sangwoo108 sangwoo108 requested a review from a team as a code owner January 19, 2024 13:43
Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ 👍🏼

@sangwoo108 sangwoo108 enabled auto-merge (squash) January 22, 2024 03:02
@sangwoo108 sangwoo108 merged commit 5a81c91 into master Jan 22, 2024
19 checks passed
@sangwoo108 sangwoo108 deleted the sko/seeker-fix branch January 22, 2024 04:52
@github-actions github-actions bot added this to the 1.64.x - Nightly milestone Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants