Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes settings content page loading error. #21676

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

mkarolin
Copy link
Collaborator

This removes "Performance" item from the advanced items on the page. We moved Performance from its own page (and path) to living under the System settings. Because there's no Route.path for this item the page throws an exception. The item doesn't make much sense on the content page since we consider it more of a systemwide setting (with the ability to add individual sites to always keep active, but that's hardly a reason to show it on the content page).

Resolves brave/brave-browser#35479

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

This removes "Performance" item from the advanced items on the page. We
moved Performance from its own page (and path) to living under the
System settings. Because there's no Route.path for this item the page
throws an exception. The item doesn't make much sense on the content
page since we consider it more of a systemwide setting (with the ability
to add individual sites to always keep active, but that's hardly a
reason to show it on the content page).
@mkarolin mkarolin added the CI/skip-ios Do not run CI builds for iOS label Jan 22, 2024
@mkarolin mkarolin self-assigned this Jan 22, 2024
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Jan 22, 2024
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@mkarolin mkarolin merged commit 4947722 into master Jan 22, 2024
20 checks passed
@mkarolin mkarolin deleted the maxk-fix-settings-content-page-loading branch January 22, 2024 17:45
@mkarolin mkarolin added this to the 1.64.x - Nightly milestone Jan 22, 2024
brave-builds added a commit that referenced this pull request Jan 22, 2024
brave-builds added a commit that referenced this pull request Jan 22, 2024
@kjozwiak
Copy link
Member

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.64.15 Chromium: 121.0.6167.75 (Official Build) nightly (64-bit)
-- | --
Revision | 3f8c7a58cc920583b5c0dc81eaa6234a7ef8528c
OS | Windows 11 Version 23H2 (Build 22631.3007)

Using the STR/Cases outlined via brave/brave-browser#35479 (comment), ensured that Site and Shield Settings was loading without any issues within brave://settings/privacy as per the following:

Example (Broken) Example (Fixed)
reproducedContentLoad fixedContentLoad

kjozwiak pushed a commit that referenced this pull request Jan 23, 2024
kjozwiak pushed a commit that referenced this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
4 participants