Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS griffin support - 1.62.x #21803

Merged
merged 2 commits into from
Jan 31, 2024
Merged

iOS griffin support - 1.62.x #21803

merged 2 commits into from
Jan 31, 2024

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Jan 29, 2024 •
edited by kjozwiak
Loading

Uplift of #21758
Uplift of #21283
Resolves brave/brave-browser#35593
Resolves brave/brave-browser#34752

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@Brandon-T @tmancey
[iOS] - Fix #34752: Add Variations Support (#21283)
0dbcac3 
- Add Variations Support for iOS
@Brandon-T @tmancey
Fix #35593: Remove browser policy connector override for iOS (#21758)
ad57be6 
- Remove browser policy connector override on iOS. 
- Desktop doesn't have it, and having it null will prevent variations and other services from working.
@tmancey tmancey self-assigned this Jan 29, 2024
@tmancey tmancey requested a review from a team as a code owner January 29, 2024 18:33
@tmancey tmancey added this to the 1.62.x - Release #4 milestone Jan 31, 2024
kjozwiak
kjozwiak approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.62.x approved 👍

@kjozwiak kjozwiak merged commit aca169c into 1.62.x Jan 31, 2024
15 checks passed
@kjozwiak kjozwiak deleted the issues/1.62.x-griffin-support branch January 31, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@aseren aseren aseren approved these changes

@Brandon-T Brandon-T Awaiting requested review from Brandon-T

Assignees

@tmancey tmancey

Labels
None yet
Projects
None yet
Milestone
1.62.x - Release #4
4 participants
@tmancey @kjozwiak @aseren @Brandon-T