-
Notifications
You must be signed in to change notification settings - Fork 837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #35593: Remove browser policy connector override for iOS #21758
Conversation
…d having it null will prevent variations and other services from working.
The security team is monitoring all repositories for certain keywords. This PR includes the word(s) "policy" and so security team members have been added as reviewers to take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- Remove browser policy connector override on iOS. - Desktop doesn't have it, and having it null will prevent variations and other services from working.
- Remove browser policy connector override on iOS. - Desktop doesn't have it, and having it null will prevent variations and other services from working.
Fix #35593: Remove browser policy connector override for iOS (#21758) - Remove browser policy connector override on iOS. - Desktop doesn't have it, and having it null will prevent variations and other services from working. Co-authored-by: Brandon-T <bthomas@brave.com>
* [iOS] - Fix #34752: Add Variations Support (#21283) - Add Variations Support for iOS * Fix #35593: Remove browser policy connector override for iOS (#21758) - Remove browser policy connector override on iOS. - Desktop doesn't have it, and having it null will prevent variations and other services from working. --------- Co-authored-by: Brandon-T <bthomas@brave.com>
Summary
Resolves brave/brave-browser#35593
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: