Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #35593: Remove browser policy connector override for iOS #21758

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

Brandon-T
Copy link
Contributor

Summary

  • Remove browser policy connector override.
  • Desktop doesn't have it, and it prevents variations and other services from working.

Resolves brave/brave-browser#35593

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

…d having it null will prevent variations and other services from working.
@Brandon-T Brandon-T added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 labels Jan 25, 2024
@Brandon-T Brandon-T added this to the 1.64.x - Nightly milestone Jan 25, 2024
@Brandon-T Brandon-T self-assigned this Jan 25, 2024
@Brandon-T Brandon-T requested a review from a team as a code owner January 25, 2024 23:05
Copy link
Contributor

The security team is monitoring all repositories for certain keywords. This PR includes the word(s) "policy" and so security team members have been added as reviewers to take a look.

No need to request a full security review at this stage, the security team will take a look shortly and either clear the label or request more information/changes.

Notifications have already been sent, but if this is blocking your merge feel free to reach out directly to the security team on Slack so that we can expedite this check.

Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Brandon-T Brandon-T merged commit 6169510 into master Jan 26, 2024
20 checks passed
@Brandon-T Brandon-T deleted the bugfix/BrowserPolicyConnectorOverrideIOS branch January 26, 2024 17:49
tmancey pushed a commit that referenced this pull request Jan 29, 2024
- Remove browser policy connector override on iOS. 
- Desktop doesn't have it, and having it null will prevent variations and other services from working.
tmancey pushed a commit that referenced this pull request Jan 29, 2024
- Remove browser policy connector override on iOS. 
- Desktop doesn't have it, and having it null will prevent variations and other services from working.
kjozwiak pushed a commit that referenced this pull request Jan 31, 2024
Fix #35593: Remove browser policy connector override for iOS (#21758)

- Remove browser policy connector override on iOS. 
- Desktop doesn't have it, and having it null will prevent variations and other services from working.

Co-authored-by: Brandon-T <bthomas@brave.com>
kjozwiak pushed a commit that referenced this pull request Jan 31, 2024
* [iOS] - Fix #34752: Add Variations Support (#21283)

- Add Variations Support for iOS

* Fix #35593: Remove browser policy connector override for iOS (#21758)

- Remove browser policy connector override on iOS. 
- Desktop doesn't have it, and having it null will prevent variations and other services from working.

---------

Co-authored-by: Brandon-T <bthomas@brave.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
5 participants